From 0284ba297c6923bea03aa346b52fc02642230a1b Mon Sep 17 00:00:00 2001 From: Jiyong Park Date: Thu, 4 Jan 2024 21:14:58 +0900 Subject: [PATCH] Set BOARD_SYSTEMSDK_VERSIONS even if PRODUCT_SHIPPING_API_LEVEL is unset Previously, we checked if PRODUCT_SHIPPING_API_LEVEL >= 28, but that no longer is needed because upgrading from 29 to 35 is not expected. All devices running Android V are expected to be shipped after 28. Furthermore, this fixes non-device targets (like sdk) where PRODUCT_SHIPPING_API_LEVEL is unset. Bug: 318634417 Test: build with sdk target Change-Id: I8f8337fb76312334777e621ae5870d953167ad49 --- core/config.mk | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/core/config.mk b/core/config.mk index 4d79e2bcb5..469be30be1 100644 --- a/core/config.mk +++ b/core/config.mk @@ -831,14 +831,10 @@ endif # Set BOARD_SYSTEMSDK_VERSIONS to the latest SystemSDK version starting from P-launching # devices if unset. ifndef BOARD_SYSTEMSDK_VERSIONS - ifdef PRODUCT_SHIPPING_API_LEVEL - ifneq ($(call math_gt_or_eq,$(PRODUCT_SHIPPING_API_LEVEL),28),) - ifeq (REL,$(PLATFORM_VERSION_CODENAME)) - BOARD_SYSTEMSDK_VERSIONS := $(PLATFORM_SDK_VERSION) - else - BOARD_SYSTEMSDK_VERSIONS := $(PLATFORM_VERSION_CODENAME) - endif - endif + ifeq (REL,$(PLATFORM_VERSION_CODENAME)) + BOARD_SYSTEMSDK_VERSIONS := $(PLATFORM_SDK_VERSION) + else + BOARD_SYSTEMSDK_VERSIONS := $(PLATFORM_VERSION_CODENAME) endif endif