From 5aded2ff26edd9d010a33e59db92029c138a6041 Mon Sep 17 00:00:00 2001 From: Anton Hansson Date: Thu, 19 Apr 2018 15:18:38 +0100 Subject: [PATCH] Move apicheck.mk off SRC_API_DIR. This directory is getting deleted. Also remove the variable, the other uses are being removed in this cl: I1d4e87e7840e979b83779a2aefe176e7c1ed1527 Bug: 77525052 Test: Verified value of last_released_sdk_version variable. Change-Id: I69b10ad83a8c06d337606df91e8d3b604adfef70 --- core/config.mk | 1 - core/tasks/apicheck.mk | 17 ++++++++++------- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/core/config.mk b/core/config.mk index c432c37a7e..a98dd21092 100644 --- a/core/config.mk +++ b/core/config.mk @@ -92,7 +92,6 @@ MAKECMDGOALS := $(strip $(filter-out dist,$(MAKECMDGOALS))) UNAME := $(shell uname -sm) SRC_TARGET_DIR := $(TOPDIR)build/target -SRC_API_DIR := $(TOPDIR)prebuilts/sdk/api SRC_SYSTEM_API_DIR := $(TOPDIR)prebuilts/sdk/system-api SRC_TEST_API_DIR := $(TOPDIR)prebuilts/sdk/test-api diff --git a/core/tasks/apicheck.mk b/core/tasks/apicheck.mk index 1d867d18df..1a1a12c7f0 100644 --- a/core/tasks/apicheck.mk +++ b/core/tasks/apicheck.mk @@ -25,11 +25,14 @@ ifeq (,$(filter true, $(WITHOUT_CHECK_API) $(TARGET_BUILD_PDK))) # Run the checkapi rules by default. droidcore: checkapi -last_released_sdk_version := $(lastword $(call numerically_sort, \ - $(filter-out current, \ - $(patsubst $(SRC_API_DIR)/%.txt,%, $(wildcard $(SRC_API_DIR)/*.txt)) \ - )\ - )) +last_released_sdk_version := \ + $(lastword $(call numerically_sort, \ + $(patsubst \ + $(HISTORICAL_SDK_VERSIONS_ROOT)/%/public/api/android.txt,\ + %,\ + $(wildcard $(HISTORICAL_SDK_VERSIONS_ROOT)/*/public/api/android.txt)\ + ) \ + )) .PHONY: check-public-api checkapi : check-public-api @@ -45,7 +48,7 @@ checkapi : check-public-api # SDK version. $(eval $(call check-api, \ checkpublicapi-last, \ - $(SRC_API_DIR)/$(last_released_sdk_version).txt, \ + $(HISTORICAL_SDK_VERSIONS_ROOT)/$(last_released_sdk_version)/public/api/android.txt, \ $(INTERNAL_PLATFORM_API_FILE), \ frameworks/base/api/removed.txt, \ $(INTERNAL_PLATFORM_REMOVED_API_FILE), \ @@ -91,7 +94,7 @@ checkapi : check-system-api # SDK version. $(eval $(call check-api, \ checksystemapi-last, \ - $(SRC_SYSTEM_API_DIR)/$(last_released_sdk_version).txt, \ + $(HISTORICAL_SDK_VERSIONS_ROOT)/$(last_released_sdk_version)/system/api/android.txt, \ $(INTERNAL_PLATFORM_SYSTEM_API_FILE), \ frameworks/base/api/system-removed.txt, \ $(INTERNAL_PLATFORM_SYSTEM_REMOVED_API_FILE), \