From 084c6ef6fa1e85a8a7e0371f8eec84e01e9f3c25 Mon Sep 17 00:00:00 2001
From: Dan Willemsen <dwillemsen@google.com>
Date: Fri, 24 Jan 2020 13:21:21 -0800
Subject: [PATCH] Deprecate BUILD_HOST_SHARED_LIBRARY

There are no common users left.

Also add some sanity checks to ensure that people don't attempt to use
LOCAL_IS_HOST_MODULE := true with the BUILD_(STATIC|SHARED)_LIBRARY
module types (I'm not sure it would work, but it definitely wouldn't be
good).

Bug: 130722971
Test: treehugger
Test: check the warnings on the build_test builds from treehugger
Change-Id: I3e571ef80379955149adbceff4500e51dfa016c6
---
 Deprecation.md         | 1 +
 core/deprecation.mk    | 2 +-
 core/shared_library.mk | 3 +++
 core/static_library.mk | 3 +++
 4 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/Deprecation.md b/Deprecation.md
index 9378e1acfd..9e9b22c153 100644
--- a/Deprecation.md
+++ b/Deprecation.md
@@ -18,6 +18,7 @@ have any problems converting, please contact us via:
 | `BUILD_AUX_STATIC_LIBRARY`       | Error     |
 | `BUILD_HOST_FUZZ_TEST`           | Error     |
 | `BUILD_HOST_NATIVE_TEST`         | Error     |
+| `BUILD_HOST_SHARED_LIBRARY`      | Warning   |
 | `BUILD_HOST_SHARED_TEST_LIBRARY` | Error     |
 | `BUILD_HOST_STATIC_LIBRARY`      | Warning   |
 | `BUILD_HOST_STATIC_TEST_LIBRARY` | Error     |
diff --git a/core/deprecation.mk b/core/deprecation.mk
index 761a9b6e52..fd71f48c69 100644
--- a/core/deprecation.mk
+++ b/core/deprecation.mk
@@ -9,7 +9,6 @@ AVAILABLE_BUILD_MODULE_TYPES :=$= \
   BUILD_HOST_EXECUTABLE \
   BUILD_HOST_JAVA_LIBRARY \
   BUILD_HOST_PREBUILT \
-  BUILD_HOST_SHARED_LIBRARY \
   BUILD_JAVA_LIBRARY \
   BUILD_MULTI_PREBUILT \
   BUILD_NATIVE_TEST \
@@ -27,6 +26,7 @@ AVAILABLE_BUILD_MODULE_TYPES :=$= \
 # relevant BUILD_BROKEN_USES_BUILD_* variables, then these would move to
 # DEFAULT_ERROR_BUILD_MODULE_TYPES.
 DEFAULT_WARNING_BUILD_MODULE_TYPES :=$= \
+  BUILD_HOST_SHARED_LIBRARY \
   BUILD_HOST_STATIC_LIBRARY \
 
 # These are BUILD_* variables that are errors to reference, but you can set
diff --git a/core/shared_library.mk b/core/shared_library.mk
index 2832c179b0..984f05f8af 100644
--- a/core/shared_library.mk
+++ b/core/shared_library.mk
@@ -1,4 +1,7 @@
 $(call record-module-type,SHARED_LIBRARY)
+ifdef LOCAL_IS_HOST_MODULE
+  $(call pretty-error,BUILD_SHARED_LIBRARY is incompatible with LOCAL_IS_HOST_MODULE. Use BUILD_HOST_SHARED_LIBRARY instead.)
+endif
 my_prefix := TARGET_
 include $(BUILD_SYSTEM)/multilib.mk
 
diff --git a/core/static_library.mk b/core/static_library.mk
index 8002e5c27c..1b056ec8ab 100644
--- a/core/static_library.mk
+++ b/core/static_library.mk
@@ -1,4 +1,7 @@
 $(call record-module-type,STATIC_LIBRARY)
+ifdef LOCAL_IS_HOST_MODULE
+  $(call pretty-error,BUILD_STATIC_LIBRARY is incompatible with LOCAL_IS_HOST_MODULE. Use BUILD_HOST_STATIC_LIBRARY instead)
+endif
 my_prefix := TARGET_
 include $(BUILD_SYSTEM)/multilib.mk