From b095acbc57ca669d74edc5866710c24e87132720 Mon Sep 17 00:00:00 2001 From: Zhi Dou Date: Mon, 2 Oct 2023 19:58:17 +0000 Subject: [PATCH] aconfig: change Map.of to Map.ofEntries in FakeFeatureFlagsImp Map.of can only take 10 entries. Map.ofEntries uses variable arguments. Bug: 303045451 Test: atest AconfigJavaHostTest Change-Id: I26a3fa0b8a731f9203934d4a800a5c695cfc730f --- tools/aconfig/src/codegen_java.rs | 12 ++++++------ .../templates/FakeFeatureFlagsImpl.java.template | 5 +++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/tools/aconfig/src/codegen_java.rs b/tools/aconfig/src/codegen_java.rs index 702ef2261d..c4fc405a61 100644 --- a/tools/aconfig/src/codegen_java.rs +++ b/tools/aconfig/src/codegen_java.rs @@ -214,12 +214,12 @@ mod tests { return value; } private Map mFlagMap = new HashMap<>( - Map.of( - Flags.FLAG_DISABLED_RO, false, - Flags.FLAG_DISABLED_RW, false, - Flags.FLAG_ENABLED_FIXED_RO, false, - Flags.FLAG_ENABLED_RO, false, - Flags.FLAG_ENABLED_RW, false + Map.ofEntries( + Map.entry(Flags.FLAG_DISABLED_RO, false), + Map.entry(Flags.FLAG_DISABLED_RW, false), + Map.entry(Flags.FLAG_ENABLED_FIXED_RO, false), + Map.entry(Flags.FLAG_ENABLED_RO, false), + Map.entry(Flags.FLAG_ENABLED_RW, false) ) ); } diff --git a/tools/aconfig/templates/FakeFeatureFlagsImpl.java.template b/tools/aconfig/templates/FakeFeatureFlagsImpl.java.template index e4a1fb7372..d2cea952f9 100644 --- a/tools/aconfig/templates/FakeFeatureFlagsImpl.java.template +++ b/tools/aconfig/templates/FakeFeatureFlagsImpl.java.template @@ -37,9 +37,10 @@ public class FakeFeatureFlagsImpl implements FeatureFlags \{ } private Map mFlagMap = new HashMap<>( - Map.of( + Map.ofEntries( {{-for item in class_elements}} - Flags.FLAG_{item.flag_name_constant_suffix}, false{{ if not @last }},{{ endif }} + Map.entry(Flags.FLAG_{item.flag_name_constant_suffix}, false) + {{ -if not @last }},{{ endif }} {{ -endfor }} ) );