From 1fe104cc13d02bc1ac582ead87a8ce3a3585802a Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Tue, 18 Sep 2018 10:16:37 -0700 Subject: [PATCH] Fix preopting Soong apps dex_preopt_odex_install.mk should always be included, it handles setting a default value for LOCAL_DEX_PREOPT. Use dexpreopt-copy-jar when preopting to strip the dex file if necessary. Bug: 115967961 Test: m SystemUI Change-Id: I74f77ed0e88a67043836407261f3845a16cbaf37 --- core/soong_app_prebuilt.mk | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/core/soong_app_prebuilt.mk b/core/soong_app_prebuilt.mk index 241a2f4dea..68916c0cda 100644 --- a/core/soong_app_prebuilt.mk +++ b/core/soong_app_prebuilt.mk @@ -43,8 +43,6 @@ endif endif # TURBINE_ENABLED != false -$(eval $(call copy-one-file,$(LOCAL_PREBUILT_MODULE_FILE),$(LOCAL_BUILT_MODULE))) - ifdef LOCAL_SOONG_RESOURCE_EXPORT_PACKAGE resource_export_package := $(intermediates.COMMON)/package-export.apk resource_export_stamp := $(intermediates.COMMON)/src/R.stamp @@ -61,14 +59,18 @@ endif # LOCAL_SOONG_RESOURCE_EXPORT_PACKAGE java-dex: $(LOCAL_SOONG_DEX_JAR) -ifdef LOCAL_DEX_PREOPT # defines built_odex along with rule to install odex include $(BUILD_SYSTEM)/dex_preopt_odex_install.mk -$(built_odex): $(LOCAL_SOONG_DEX_JAR) +ifdef LOCAL_DEX_PREOPT + $(built_odex): $(LOCAL_SOONG_DEX_JAR) $(call dexpreopt-one-file,$<,$@) + $(eval $(call dexpreopt-copy-jar,$(LOCAL_PREBUILT_MODULE_FILE),$(LOCAL_BUILT_MODULE),$(LOCAL_DEX_PREOPT))) +else + $(eval $(call copy-one-file,$(LOCAL_PREBUILT_MODULE_FILE),$(LOCAL_BUILT_MODULE))) endif + PACKAGES := $(PACKAGES) $(LOCAL_MODULE) ifdef LOCAL_CERTIFICATE PACKAGES.$(LOCAL_MODULE).CERTIFICATE := $(LOCAL_CERTIFICATE)