From 9d021e996bf66cb6ff9f9cd5889853fa79e4d3fd Mon Sep 17 00:00:00 2001 From: Kelvin Zhang Date: Mon, 7 Feb 2022 16:37:15 -0800 Subject: [PATCH] Fix small misuse of pass The intention is to skip current iteration of for loop, so 'continue' should be used instead of 'pass' Test: th Change-Id: Ic955beeaef74100981b351e2e7807c7fde538783 --- tools/releasetools/add_img_to_target_files.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/releasetools/add_img_to_target_files.py b/tools/releasetools/add_img_to_target_files.py index 4be2ceaf6a..9a9fba148d 100644 --- a/tools/releasetools/add_img_to_target_files.py +++ b/tools/releasetools/add_img_to_target_files.py @@ -1027,10 +1027,10 @@ def OptimizeCompressedEntries(zipfile_path): with zipfile.ZipFile(zipfile_path, "r", allowZip64=True) as zfp: for zinfo in zfp.filelist: if not zinfo.filename.startswith("IMAGES/") and not zinfo.filename.startswith("META"): - pass + continue # Don't try to store userdata.img uncompressed, it's usually huge. if zinfo.filename.endswith("userdata.img"): - pass + continue if zinfo.compress_size > zinfo.file_size * 0.80 and zinfo.compress_type != zipfile.ZIP_STORED: entries_to_store.append(zinfo) zfp.extract(zinfo, tmpdir)