From 29445bd9352db633f218e72dd87b7030cd8c1dea Mon Sep 17 00:00:00 2001 From: Kiyoung Kim Date: Mon, 25 Sep 2023 16:25:20 +0900 Subject: [PATCH] Do not compare KEEP_VNDK with false Overall android build system assumes empty value as false, so comparing KEEP_VNDK value with false can cause unexpected problem in the future. It should be changed to compare with true in opposite way. Bug: 299197187 Test: aosp_cf build succeeded with KEEP_VNDK=false Change-Id: I5db685c2735309a14ea6bdb8b8928b2aa987929f --- core/main.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/main.mk b/core/main.mk index e697d043b0..7c25862530 100644 --- a/core/main.mk +++ b/core/main.mk @@ -220,7 +220,7 @@ ADDITIONAL_SYSTEM_PROPERTIES += ro.postinstall.fstab.prefix=/system # property_overrides_split_enabled is true. Otherwise it will be installed in # /system/build.prop ifdef BOARD_VNDK_VERSION - ifneq ($(KEEP_VNDK),false) + ifeq ($(KEEP_VNDK),true) ifeq ($(BOARD_VNDK_VERSION),current) ADDITIONAL_VENDOR_PROPERTIES := ro.vndk.version=$(PLATFORM_VNDK_VERSION) else @@ -339,7 +339,7 @@ endif # modules. It uses the version in PRODUCT_PRODUCT_VNDK_VERSION. If the value # is "current", use PLATFORM_VNDK_VERSION. ifdef PRODUCT_PRODUCT_VNDK_VERSION -ifneq ($(KEEP_VNDK),false) +ifeq ($(KEEP_VNDK),true) ifeq ($(PRODUCT_PRODUCT_VNDK_VERSION),current) ADDITIONAL_PRODUCT_PROPERTIES += ro.product.vndk.version=$(PLATFORM_VNDK_VERSION) else