From 2a386e0cfbdfa009038acede85876a7643f297f5 Mon Sep 17 00:00:00 2001 From: Ying Wang Date: Tue, 3 Jun 2014 14:07:27 -0700 Subject: [PATCH] Allow to build the update.zip for emulator build. img_from_target_files.py just skips the boot.img and recovery.img since there is no kernel or recovery.fstab for emulator. Bug: 15383279 Change-Id: I4035193e6ab933194ff1417dfae4eab963fe5301 --- core/Makefile | 9 +++++---- tools/releasetools/common.py | 2 ++ tools/releasetools/img_from_target_files | 13 ++++++++----- 3 files changed, 15 insertions(+), 9 deletions(-) diff --git a/core/Makefile b/core/Makefile index 27f22a976a..1810c6283c 100644 --- a/core/Makefile +++ b/core/Makefile @@ -1306,6 +1306,11 @@ $(INTERNAL_OTA_PACKAGE_TARGET): $(BUILT_TARGET_FILES_PACKAGE) $(DISTTOOLS) .PHONY: otapackage otapackage: $(INTERNAL_OTA_PACKAGE_TARGET) +endif # recovery_fstab is defined +endif # TARGET_NO_KERNEL != true +endif # TARGET_DEVICE != generic* +endif # TARGET_PRODUCT != sdk + # ----------------------------------------------------------------- # The update package @@ -1334,10 +1339,6 @@ $(INTERNAL_UPDATE_PACKAGE_TARGET): $(BUILT_TARGET_FILES_PACKAGE) $(DISTTOOLS) .PHONY: updatepackage updatepackage: $(INTERNAL_UPDATE_PACKAGE_TARGET) -endif # recovery_fstab is defined -endif # TARGET_NO_KERNEL != true -endif # TARGET_DEVICE != generic* -endif # TARGET_PRODUCT != sdk ifdef is_tests_build # ----------------------------------------------------------------- diff --git a/tools/releasetools/common.py b/tools/releasetools/common.py index a3217dd9a3..80bb10aea6 100644 --- a/tools/releasetools/common.py +++ b/tools/releasetools/common.py @@ -482,6 +482,8 @@ def CheckSize(data, target, info_dict): if target.endswith(".img"): target = target[:-4] mount_point = "/" + target + fs_type = None + limit = None if info_dict["fstab"]: if mount_point == "/userdata": mount_point = "/data" p = info_dict["fstab"][mount_point] diff --git a/tools/releasetools/img_from_target_files b/tools/releasetools/img_from_target_files index e894c42639..d23d465bb6 100755 --- a/tools/releasetools/img_from_target_files +++ b/tools/releasetools/img_from_target_files @@ -239,11 +239,14 @@ def main(argv): output_zip = zipfile.ZipFile(args[1], "w", compression=zipfile.ZIP_DEFLATED) - common.GetBootableImage( - "boot.img", "boot.img", OPTIONS.input_tmp, "BOOT").AddToZip(output_zip) - common.GetBootableImage( - "recovery.img", "recovery.img", OPTIONS.input_tmp, - "RECOVERY").AddToZip(output_zip) + boot_image = common.GetBootableImage( + "boot.img", "boot.img", OPTIONS.input_tmp, "BOOT") + if boot_image: + boot_image.AddToZip(output_zip) + recovery_image = common.GetBootableImage( + "recovery.img", "recovery.img", OPTIONS.input_tmp, "RECOVERY") + if recovery_image: + recovery_image.AddToZip(output_zip) if not bootable_only: AddSystem(output_zip)