From 9214a26cfc377736ebeb26ce47b84c671281a099 Mon Sep 17 00:00:00 2001 From: Yohann Roussel Date: Thu, 3 Dec 2015 10:23:33 +0100 Subject: [PATCH] Always start jack server before first call to jack Also install and update the server if necessary. The target start-jack-server produces no file so it's always built. Since the dependency is "order only", it doesn't cause force rebuilt of jack targets after start-jack-server execution. Bug: 25443108 Change-Id: I1608d87d186694d47307e00337b1905f0b8079c4 --- core/host_dalvik_java_library.mk | 2 +- core/host_dalvik_static_java_library.mk | 2 +- core/java.mk | 6 +++--- core/main.mk | 5 +++++ core/prebuilt_internal.mk | 2 +- 5 files changed, 11 insertions(+), 6 deletions(-) diff --git a/core/host_dalvik_java_library.mk b/core/host_dalvik_java_library.mk index 59ecf4e198..62ef45242e 100644 --- a/core/host_dalvik_java_library.mk +++ b/core/host_dalvik_java_library.mk @@ -126,7 +126,7 @@ $(built_dex): PRIVATE_JACK_FLAGS := $(GLOBAL_JAVAC_DEBUG_FLAGS) $(LOCAL_JACK_FLA $(built_dex): PRIVATE_JACK_VERSION := $(LOCAL_JACK_VERSION) $(built_dex): $(java_sources) $(java_resource_sources) $(full_jack_lib_deps) \ $(jar_manifest_file) $(proto_java_sources_file_stamp) $(LOCAL_MODULE_MAKEFILE_DEP) \ - $(LOCAL_ADDITIONAL_DEPENDENCIES) $(JACK) + $(LOCAL_ADDITIONAL_DEPENDENCIES) $(JACK) | setup-jack-server @echo Building with Jack: $@ $(jack-java-to-dex) diff --git a/core/host_dalvik_static_java_library.mk b/core/host_dalvik_static_java_library.mk index 6248e1a0c1..6a680b4bb5 100644 --- a/core/host_dalvik_static_java_library.mk +++ b/core/host_dalvik_static_java_library.mk @@ -49,7 +49,7 @@ endif $(full_classes_jack): $(java_sources) $(java_resource_sources) $(full_jack_lib_deps) \ $(jar_manifest_file) $(layers_file) $(LOCAL_MODULE_MAKEFILE_DEP) \ $(LOCAL_ADDITIONAL_DEPENDENCIES) $(LOCAL_JARJAR_RULES) \ - $(JACK) + $(JACK) | setup-jack-server @echo Building with Jack: $@ $(java-to-jack) diff --git a/core/java.mk b/core/java.mk index f9305df7ea..a6ff6f5e10 100644 --- a/core/java.mk +++ b/core/java.mk @@ -652,14 +652,14 @@ jack_all_deps := $(java_sources) $(java_resource_sources) $(full_jack_lib_deps) $(LOCAL_MODULE_MAKEFILE_DEP) $(JACK) ifeq ($(LOCAL_IS_STATIC_JAVA_LIBRARY),true) -$(full_classes_jack): $(jack_all_deps) +$(full_classes_jack): $(jack_all_deps) | setup-jack-server @echo Building with Jack: $@ $(java-to-jack) else #LOCAL_IS_STATIC_JAVA_LIBRARY $(built_dex_intermediate): PRIVATE_CLASSES_JACK := $(full_classes_jack) -$(built_dex_intermediate): $(jack_all_deps) +$(built_dex_intermediate): $(jack_all_deps) | setup-jack-server @echo Building with Jack: $@ $(jack-java-to-dex) @@ -678,7 +678,7 @@ else $(noshrob_classes_jack): PRIVATE_JACK_INCREMENTAL_DIR := endif $(noshrob_classes_jack): PRIVATE_JACK_PROGUARD_FLAGS := -$(noshrob_classes_jack): $(jack_all_deps) +$(noshrob_classes_jack): $(jack_all_deps) | setup-jack-server @echo Building with Jack: $@ $(java-to-jack) endif # full_classes_jar is defined diff --git a/core/main.mk b/core/main.mk index 2bd3163068..004a3769b7 100644 --- a/core/main.mk +++ b/core/main.mk @@ -319,6 +319,11 @@ include build/core/pdk_config.mk -include $(TOPDIR)prebuilts/sdk/tools/jack_versions.mk -include $(TOPDIR)prebuilts/sdk/tools/jack_for_module.mk +# +# ----------------------------------------------------------------- +# Install and start Jack server +-include $(TOPDIR)prebuilts/sdk/tools/jack_server_setup.mk + # ----------------------------------------------------------------- ### ### In this section we set up the things that are different diff --git a/core/prebuilt_internal.mk b/core/prebuilt_internal.mk index da76eb900b..2dd392b7ee 100644 --- a/core/prebuilt_internal.mk +++ b/core/prebuilt_internal.mk @@ -322,7 +322,7 @@ endif # TARGET JAVA_LIBRARIES ifeq ($(LOCAL_MODULE_CLASS),JAVA_LIBRARIES) $(intermediates.COMMON)/classes.jack : PRIVATE_JILL_FLAGS:=$(LOCAL_JILL_FLAGS) $(intermediates.COMMON)/classes.jack : $(my_src_jar) $(LOCAL_MODULE_MAKEFILE_DEP) \ - $(LOCAL_ADDITIONAL_DEPENDENCIES) $(JILL_JAR) $(JACK) + $(LOCAL_ADDITIONAL_DEPENDENCIES) $(JILL_JAR) $(JACK) | setup-jack-server $(transform-jar-to-jack) endif # JAVA_LIBRARIES