From d10112751aa17d995892f62f3fea27037b8b799a Mon Sep 17 00:00:00 2001 From: Dario Freni Date: Mon, 23 Jul 2018 20:20:15 +0100 Subject: [PATCH] Generate a zipfile with appcompat logs during dist. Test: m dist Bug: 110073830 Bug: 78924201 Change-Id: I052034ab35365e7add9a9992a51022c20aa50718 --- core/Makefile | 22 ++++++++++++++++++++++ core/main.mk | 5 +++++ 2 files changed, 27 insertions(+) diff --git a/core/Makefile b/core/Makefile index d694f8587a..23bea6d0e3 100644 --- a/core/Makefile +++ b/core/Makefile @@ -3192,6 +3192,27 @@ $(INTERNAL_UPDATE_PACKAGE_TARGET): $(BUILT_TARGET_FILES_PACKAGE) $(ZIP2ZIP) .PHONY: updatepackage updatepackage: $(INTERNAL_UPDATE_PACKAGE_TARGET) +# ----------------------------------------------------------------- +# A zip of the appcompat directory containing logs +APPCOMPAT_ZIP := $(PRODUCT_OUT)/appcompat.zip +# For apps_only build we'll establish the dependency later in build/make/core/main.mk. +ifndef TARGET_BUILD_APPS +$(APPCOMPAT_ZIP): $(INSTALLED_SYSTEMIMAGE) \ + $(INSTALLED_BOOTIMAGE_TARGET) \ + $(INSTALLED_USERDATAIMAGE_TARGET) \ + $(INSTALLED_VENDORIMAGE_TARGET) \ + $(INSTALLED_PRODUCTIMAGE_TARGET) \ + $(INSTALLED_PRODUCT_SERVICESIMAGE_TARGET) +endif +$(APPCOMPAT_ZIP): PRIVATE_LIST_FILE := $(call intermediates-dir-for,PACKAGING,appcompat)/filelist +$(APPCOMPAT_ZIP): $(SOONG_ZIP) + @echo "appcompat logs: $@" + $(hide) rm -rf $@ $(PRIVATE_LIST_FILE) + $(hide) mkdir -p $(dir $@) $(PRODUCT_OUT)/appcompat $(dir $(PRIVATE_LIST_FILE)) + $(hide) find $(PRODUCT_OUT)/appcompat | sort >$(PRIVATE_LIST_FILE) + $(hide) $(SOONG_ZIP) -d -o $@ -C $(PRODUCT_OUT)/appcompat -l $(PRIVATE_LIST_FILE) + + # ----------------------------------------------------------------- # A zip of the symbols directory. Keep the full paths to make it # more obvious where these files came from. @@ -3448,6 +3469,7 @@ deps := \ $(OUT_DOCS)/offline-sdk-timestamp \ $(SYMBOLS_ZIP) \ $(COVERAGE_ZIP) \ + $(APPCOMPAT_ZIP) \ $(INSTALLED_SYSTEMIMAGE) \ $(INSTALLED_QEMU_SYSTEMIMAGE) \ $(INSTALLED_QEMU_VENDORIMAGE) \ diff --git a/core/main.mk b/core/main.mk index 7d27ef3f7c..97899c6322 100644 --- a/core/main.mk +++ b/core/main.mk @@ -1258,6 +1258,9 @@ ifneq ($(TARGET_BUILD_APPS),) $(COVERAGE_ZIP) : $(apps_only_installed_files) $(call dist-for-goals,apps_only, $(COVERAGE_ZIP)) + $(APPCOMPAT_ZIP) : $(apps_only_installed_files) + $(call dist-for-goals,apps_only, $(APPCOMPAT_ZIP)) + .PHONY: apps_only apps_only: $(unbundled_build_modules) @@ -1279,6 +1282,7 @@ else # TARGET_BUILD_APPS $(BUILT_OTATOOLS_PACKAGE) \ $(SYMBOLS_ZIP) \ $(COVERAGE_ZIP) \ + $(APPCOMPAT_ZIP) \ $(INSTALLED_FILES_FILE) \ $(INSTALLED_FILES_JSON) \ $(INSTALLED_FILES_FILE_VENDOR) \ @@ -1366,6 +1370,7 @@ $(call dist-for-goals,sdk win_sdk, \ $(ALL_SDK_TARGETS) \ $(SYMBOLS_ZIP) \ $(COVERAGE_ZIP) \ + $(APPCOMPAT_ZIP) \ $(INSTALLED_BUILD_PROP_TARGET) \ )