From 89a470255549852cd1f86391e6279b73320e4727 Mon Sep 17 00:00:00 2001 From: Sam Delmerico Date: Tue, 5 Apr 2022 13:44:18 +0000 Subject: [PATCH] prevent unintended m bp2build "" when running b cl/2045666 allowed the --skip-soong-tests flag to pass through invocations of the `b` command to soong_ui. But when the flag was missing, an extra `""` argument was passed instead which caused soong_ui to invoke a build of the droid target. Test: m clean && b build '...' # verify Soong does not run a build Change-Id: I7b99437d225786eb1698a88d0c755ce897550e70 --- envsetup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/envsetup.sh b/envsetup.sh index 7331d5ec27..6b04eed69e 100644 --- a/envsetup.sh +++ b/envsetup.sh @@ -1730,7 +1730,7 @@ function b() local skip_tests=$(echo "$@" | grep -ow -- "--skip-soong-tests") local bazel_args=(${@/--skip-soong-tests/}) # Generate BUILD, bzl files into the synthetic Bazel workspace (out/soong/workspace). - _trigger_build "all-modules" bp2build USE_BAZEL_ANALYSIS= "$skip_tests" || return 1 + _trigger_build "all-modules" bp2build USE_BAZEL_ANALYSIS= $skip_tests || return 1 # Then, run Bazel using the synthetic workspace as the --package_path. if [[ -z "$bazel_args" ]]; then # If there are no args, show help.