Regularize command-line flags.
All the notice binaries have -title All the binaries that can -stripPrefix can strip multiple. Bug: 68860345 Bug: 151177513 Bug: 151953481 Bug: 213388645 Bug: 210912771 Test: m all Test: m systemlicense Test: m bom; out/soong/host/linux-x85/bom ... Test: m dumpgraph; out/soong/host/linux-x85/dumpgraph ... Test: m dumpresolutions; out/soong/host/linux-x85/dumpresolutions ... Test: m htmlnotice; out/soong/host/linux-x85/htmlnotice ... Test: m rtrace; out/soong/host/linux-x85/rtrace ... Test: m textnotice; out/soong/host/linux-x85/textnotice ... Test: m xmlnotice; out/soong/host/linux-x85/xmlnotice ... where ... is the path to the .meta_lic file for the system image. In my case if $ export PRODUCT=$(realpath $ANDROID_PRODUCT_OUT --relative-to=$PWD) ... can be expressed as: ${PRODUCT}/gen/META/lic_intermediates/${PRODUCT}/system.img.meta_lic Change-Id: I08357bf1adb048abba6563cf3cea6ee6d60405e0
This commit is contained in:
@@ -29,7 +29,7 @@ import (
|
||||
var (
|
||||
graphViz = flag.Bool("dot", false, "Whether to output graphviz (i.e. dot) format.")
|
||||
labelConditions = flag.Bool("label_conditions", false, "Whether to label target nodes with conditions.")
|
||||
stripPrefix = flag.String("strip_prefix", "", "Prefix to remove from paths. i.e. path to root")
|
||||
stripPrefix = newMultiString("strip_prefix", "Prefix to remove from paths. i.e. path to root (multiple allowed)")
|
||||
|
||||
failNoneRequested = fmt.Errorf("\nNo license metadata files requested")
|
||||
failNoLicenses = fmt.Errorf("No licenses found")
|
||||
@@ -38,7 +38,20 @@ var (
|
||||
type context struct {
|
||||
graphViz bool
|
||||
labelConditions bool
|
||||
stripPrefix string
|
||||
stripPrefix []string
|
||||
}
|
||||
|
||||
func (ctx context) strip(installPath string) string {
|
||||
for _, prefix := range ctx.stripPrefix {
|
||||
if strings.HasPrefix(installPath, prefix) {
|
||||
p := strings.TrimPrefix(installPath, prefix)
|
||||
if 0 == len(p) {
|
||||
continue
|
||||
}
|
||||
return p
|
||||
}
|
||||
}
|
||||
return installPath
|
||||
}
|
||||
|
||||
func init() {
|
||||
@@ -60,6 +73,19 @@ Options:
|
||||
}
|
||||
}
|
||||
|
||||
// newMultiString creates a flag that allows multiple values in an array.
|
||||
func newMultiString(name, usage string) *multiString {
|
||||
var f multiString
|
||||
flag.Var(&f, name, usage)
|
||||
return &f
|
||||
}
|
||||
|
||||
// multiString implements the flag `Value` interface for multiple strings.
|
||||
type multiString []string
|
||||
|
||||
func (ms *multiString) String() string { return strings.Join(*ms, ", ") }
|
||||
func (ms *multiString) Set(s string) error { *ms = append(*ms, s); return nil }
|
||||
|
||||
func main() {
|
||||
flag.Parse()
|
||||
|
||||
@@ -107,7 +133,7 @@ func dumpGraph(ctx *context, stdout, stderr io.Writer, files ...string) error {
|
||||
|
||||
// targetOut calculates the string to output for `target` separating conditions as needed using `sep`.
|
||||
targetOut := func(target *compliance.TargetNode, sep string) string {
|
||||
tOut := strings.TrimPrefix(target.Name(), ctx.stripPrefix)
|
||||
tOut := ctx.strip(target.Name())
|
||||
if ctx.labelConditions {
|
||||
conditions := target.LicenseConditions().Names()
|
||||
sort.Strings(conditions)
|
||||
|
Reference in New Issue
Block a user