From 753d1ad14e3a08650ebd9e9b3ee84dc4292f95c1 Mon Sep 17 00:00:00 2001 From: Dan Willemsen Date: Sat, 25 May 2019 17:20:38 -0700 Subject: [PATCH] Mark more BUILD_* as obsolete These have been warnings for a couple weeks now, with no hits. BUILD_AUX_EXECUTABLE BUILD_AUX_STATIC_LIBRARY BUILD_HOST_FUZZ_TEST BUILD_HOST_NATIVE_TEST BUILD_HOST_STATIC_TEST_LIBRARY BUILD_NATIVE_BENCHMARK BUILD_STATIC_TEST_LIBRARY Fixes: 130735607 Fixes: 130735003 Fixes: 130691889 Fixes: 130723134 Fixes: 130722660 Fixes: 130734558 Fixes: 130735594 Test: check all downstream build_test logs Change-Id: Ia13e59200af8f77a79d6a17d94913b79d8970055 --- Deprecation.md | 14 +++++++------- core/deprecation.mk | 14 +++++++------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/Deprecation.md b/Deprecation.md index 0d925cbc58..131ec0d11d 100644 --- a/Deprecation.md +++ b/Deprecation.md @@ -14,16 +14,16 @@ have any problems converting, please contact us via: | Module type | State | | -------------------------------- | --------- | -| `BUILD_AUX_EXECUTABLE` | Warning | -| `BUILD_AUX_STATIC_LIBRARY` | Warning | -| `BUILD_HOST_FUZZ_TEST` | Warning | -| `BUILD_HOST_NATIVE_TEST` | Warning | +| `BUILD_AUX_EXECUTABLE` | Error | +| `BUILD_AUX_STATIC_LIBRARY` | Error | +| `BUILD_HOST_FUZZ_TEST` | Error | +| `BUILD_HOST_NATIVE_TEST` | Error | | `BUILD_HOST_SHARED_TEST_LIBRARY` | Error | -| `BUILD_HOST_STATIC_TEST_LIBRARY` | Warning | +| `BUILD_HOST_STATIC_TEST_LIBRARY` | Error | | `BUILD_HOST_TEST_CONFIG` | Error | -| `BUILD_NATIVE_BENCHMARK` | Warning | +| `BUILD_NATIVE_BENCHMARK` | Error | | `BUILD_SHARED_TEST_LIBRARY` | Error | -| `BUILD_STATIC_TEST_LIBRARY` | Warning | +| `BUILD_STATIC_TEST_LIBRARY` | Error | | `BUILD_TARGET_TEST_CONFIG` | Error | | `BUILD_*` | Available | diff --git a/core/deprecation.mk b/core/deprecation.mk index 11fe290bd5..f1e198d518 100644 --- a/core/deprecation.mk +++ b/core/deprecation.mk @@ -28,19 +28,19 @@ AVAILABLE_BUILD_MODULE_TYPES :=$= \ # relevant BUILD_BROKEN_USES_BUILD_* variables, then these would move to # DEFAULT_ERROR_BUILD_MODULE_TYPES. DEFAULT_WARNING_BUILD_MODULE_TYPES :=$= \ - BUILD_AUX_EXECUTABLE \ - BUILD_AUX_STATIC_LIBRARY \ - BUILD_HOST_FUZZ_TEST \ - BUILD_HOST_NATIVE_TEST \ - BUILD_HOST_STATIC_TEST_LIBRARY \ - BUILD_NATIVE_BENCHMARK \ - BUILD_STATIC_TEST_LIBRARY \ # These are BUILD_* variables that are errors to reference, but you can set # BUILD_BROKEN_USES_BUILD_* in your BoardConfig.mk in order to turn them back # to warnings. DEFAULT_ERROR_BUILD_MODULE_TYPES :=$= \ + BUILD_AUX_EXECUTABLE \ + BUILD_AUX_STATIC_LIBRARY \ + BUILD_HOST_FUZZ_TEST \ + BUILD_HOST_NATIVE_TEST \ + BUILD_HOST_STATIC_TEST_LIBRARY \ BUILD_HOST_TEST_CONFIG \ + BUILD_NATIVE_BENCHMARK \ + BUILD_STATIC_TEST_LIBRARY \ BUILD_TARGET_TEST_CONFIG \ # These are BUILD_* variables that are always errors to reference.