Merge changes from topic "colefaust_artifact_path_requirements"

* changes:
  Add artifact path requirement support to Starlark
  Support `m product-graph` in Starlark product config
This commit is contained in:
Treehugger Robot
2022-04-08 17:32:25 +00:00
committed by Gerrit Code Review
7 changed files with 58 additions and 72 deletions

View File

@@ -1234,33 +1234,9 @@ endef
# See the select-bitness-of-required-modules definition.
# $(1): product makefile
# TODO(asmundak):
# `product-installed-files` and `host-installed-files` macros below used to
# call `get-product-var` directly to obtain per-file configuration variable
# values (the value of variable FOO is fetched from PRODUCT.<product-makefile>.FOO).
# Starlark-based configuration does not maintain per-file variable variable
# values. To work around this problem, we utilize the fact that
# `product-installed-files` and `host-installed-files` are called only in
# two places:
# 1. For the top-level product makefile (in this file). In this case
# $(call get-product-var <product>, FOO) is the same as $(FOO) as the
# product configuration has been run already. Therefore we define
# _product-var macro to pick the values directly from product config
# variables when using Starlark-based configuration.
# 2. To check the path requirements (in artifact_path_requirements.mk).
# Starlark-based configuration does not perform this check at the moment.
# In the longer run most of the logic of this file will be moved to the
# Starlark.
ifndef RBC_PRODUCT_CONFIG
define _product-var
$(call get-product-var,$(1),$(2))
endef
else
define _product-var
$(call $(2))
endef
endif
define product-installed-files
$(eval _pif_modules := \
@@ -1375,7 +1351,7 @@ else ifdef FULL_BUILD
# Verify the artifact path requirements made by included products.
is_asan := $(if $(filter address,$(SANITIZE_TARGET)),true)
ifeq (,$(or $(is_asan),$(DISABLE_ARTIFACT_PATH_REQUIREMENTS),$(RBC_PRODUCT_CONFIG),$(RBC_BOARD_CONFIG)))
ifeq (,$(or $(is_asan),$(DISABLE_ARTIFACT_PATH_REQUIREMENTS)))
include $(BUILD_SYSTEM)/artifact_path_requirements.mk
endif
else