From ed56902c29e984b987089e13a27f9f25ac6c6e42 Mon Sep 17 00:00:00 2001 From: Ying Wang Date: Tue, 18 Mar 2014 15:12:29 -0700 Subject: [PATCH] Remove arm64 clang build warning Now we have enabled arm64 clang. This change remvoed arm64 clang build warning and cleaned the arm64 unknow c flags. Change-Id: Ia583a78c6d364e603ff09df423aa34a6e03d0b9b --- core/clang/TARGET_arm64.mk | 1 - core/clang/arm64.mk | 10 ++-------- core/combo/TARGET_linux-arm64.mk | 3 --- 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/core/clang/TARGET_arm64.mk b/core/clang/TARGET_arm64.mk index 9134f1d57c..98bbeb2340 100644 --- a/core/clang/TARGET_arm64.mk +++ b/core/clang/TARGET_arm64.mk @@ -50,5 +50,4 @@ CLANG_TARGET_GLOBAL_LDFLAGS := \ $(call convert-to-clang-flags,$(TARGET_GLOBAL_LDFLAGS)) \ $(CLANG_CONFIG_arm64_TARGET_EXTRA_LDFLAGS) -$(warning Incorrect arm64 RS_TRIPLE, fix me!) RS_TRIPLE := aarch64-linux-android diff --git a/core/clang/arm64.mk b/core/clang/arm64.mk index a52a662c1a..c9fef389c5 100644 --- a/core/clang/arm64.mk +++ b/core/clang/arm64.mk @@ -1,7 +1,5 @@ # Clang flags for arm64 arch, target or host. -$(warning Untested arm64 clang flags, fix me!) - CLANG_CONFIG_arm64_EXTRA_ASFLAGS := CLANG_CONFIG_arm64_EXTRA_CFLAGS := \ @@ -12,18 +10,14 @@ CLANG_CONFIG_arm64_EXTRA_LDFLAGS := # Include common unknown flags CLANG_CONFIG_arm64_UNKNOWN_CFLAGS := \ $(CLANG_CONFIG_UNKNOWN_CFLAGS) \ - -mthumb-interwork \ -fgcse-after-reload \ -frerun-cse-after-loop \ -frename-registers \ - -fno-builtin-sin \ -fno-strict-volatile-bitfields \ -fno-align-jumps \ -Wa,--noexecstack +# We don't have any arm64 flags to substitute yet. define subst-clang-incompatible-arm64-flags - $(subst -march=armv5te,-march=armv5t,\ - $(subst -march=armv5e,-march=armv5,\ - $(subst -mcpu=cortex-a15,-march=armv7-a,\ - $(1)))) + $(1) endef diff --git a/core/combo/TARGET_linux-arm64.mk b/core/combo/TARGET_linux-arm64.mk index 15228340cd..f130311b14 100644 --- a/core/combo/TARGET_linux-arm64.mk +++ b/core/combo/TARGET_linux-arm64.mk @@ -47,9 +47,6 @@ ifeq ($(strip $(wildcard $(TARGET_ARCH_SPECIFIC_MAKEFILE))),) $(error Unknown ARM architecture version: $(TARGET_ARCH_VARIANT)) endif -# TODO: Enable Clang when aarch64 prebuilt is added -# WITHOUT_TARGET_CLANG := true - include $(TARGET_ARCH_SPECIFIC_MAKEFILE) # You can set TARGET_TOOLS_PREFIX to get gcc from somewhere else