StrixOS/build
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up some kati warnings

Browse Source 
Kati has a `--warn` option that adds some extra Kati-specific warnings
-- like using undefined make functions, undefined user functions, likely
bad variable lookups, etc. Some of these are bugs, others are fine doing
nothing. This fixes up all of them in the core build system.

It also complains about $(eval) usage in a recipe not being recommended.
Those aren't handled as part of this change.

Bug: 72661763
Test: build-aosp_arm.ninja is identical before and after
Change-Id: I8e00af142a7745236d3ad4efc9e91ec3ce71a511
This commit is contained in:
Dan Willemsen
2018-01-29 16:18:40 -08:00
parent d8e3c4eb07
commit 893bebc44b
7 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/shared_library_internal.mk
View File

@@ -20,7 +20,9 @@ ifneq ($(strip $(LOCAL_MODULE_STEM)$(LOCAL_BUILT_MODULE_STEM)$(LOCAL_MODULE_STEM
$(error $(LOCAL_PATH): Cannot set module stem for a library)
endif
ifdef target-shared-library-hook
$(call target-shared-library-hook)
endif
skip_build_from_source :=
ifdef LOCAL_PREBUILT_MODULE_FILE