From 87e452739e5d0210fa0fd6f29475e39789654a17 Mon Sep 17 00:00:00 2001 From: Kelvin Zhang Date: Wed, 27 Jul 2022 11:14:12 -0700 Subject: [PATCH] Fix typo in recently changed extra_apex_payload_key flag The intention was to make extra_apex_payload_key take a comma separted list of keys. Iterating over a string will only iterate over each characters individually. Must split by "," to iterate over keys. Test: Run signing test locally using tradefed.sh Bug: 239991438 Change-Id: I51bfed53a43b1b0fc1e33e0dc3d418a727e6ff15 --- tools/releasetools/sign_target_files_apks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/releasetools/sign_target_files_apks.py b/tools/releasetools/sign_target_files_apks.py index dbe79aba09..4f2b1bfd66 100755 --- a/tools/releasetools/sign_target_files_apks.py +++ b/tools/releasetools/sign_target_files_apks.py @@ -1381,7 +1381,7 @@ def main(argv): OPTIONS.extra_apks[n] = key elif o == "--extra_apex_payload_key": apex_names, key = a.split("=") - for name in apex_names: + for name in apex_names.split(","): OPTIONS.extra_apex_payload_keys[name] = key elif o == "--skip_apks_with_path_prefix": # Check the prefix, which must be in all upper case.