StrixOS/build
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Mark FeatureFlags impl member as final" into main

Browse Source
This commit is contained in:
Treehugger Robot
2024-07-03 15:52:13 +00:00
committed by Gerrit Code Review
parent 1006bfbae3 fca73bcad3
commit 8d3b98e1ca
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tools/aconfig/aconfig/src/codegen/java.rs
View File

@@ -482,7 +482,7 @@ mod tests {
.unwrap(); .unwrap();
let expect_flags_content = EXPECTED_FLAG_COMMON_CONTENT.to_string() let expect_flags_content = EXPECTED_FLAG_COMMON_CONTENT.to_string()
+ r#" + r#"
private static FeatureFlags FEATURE_FLAGS = new FeatureFlagsImpl(); private static final FeatureFlags FEATURE_FLAGS = new FeatureFlagsImpl();
}"#; }"#;
let expect_featureflagsimpl_content = r#" let expect_featureflagsimpl_content = r#"
@@ -670,7 +670,7 @@ mod tests {
public static boolean enabledRoExported() { public static boolean enabledRoExported() {
return FEATURE_FLAGS.enabledRoExported(); return FEATURE_FLAGS.enabledRoExported();
} }
private static FeatureFlags FEATURE_FLAGS = new FeatureFlagsImpl(); private static final FeatureFlags FEATURE_FLAGS = new FeatureFlagsImpl();
} }
"#; "#;
@@ -1092,7 +1092,7 @@ mod tests {
public static boolean enabledRw() { public static boolean enabledRw() {
return FEATURE_FLAGS.enabledRw(); return FEATURE_FLAGS.enabledRw();
} }
private static FeatureFlags FEATURE_FLAGS = new FeatureFlagsImpl(); private static final FeatureFlags FEATURE_FLAGS = new FeatureFlagsImpl();
}"#; }"#;
let expect_customfeatureflags_content = r#" let expect_customfeatureflags_content = r#"

7
tools/aconfig/aconfig/templates/Flags.java.template
View File

@@ -33,8 +33,11 @@ public final class Flags \{
public static void unsetFeatureFlags() \{ public static void unsetFeatureFlags() \{
Flags.FEATURE_FLAGS = null; Flags.FEATURE_FLAGS = null;
} }
private static FeatureFlags FEATURE_FLAGS;
{{ -else }}
private static final FeatureFlags FEATURE_FLAGS = new FeatureFlagsImpl();
{{ -endif }} {{ -endif }}
private static FeatureFlags FEATURE_FLAGS{{ -if not is_test_mode }} = new FeatureFlagsImpl(){{ -endif- }};
} }