StrixOS/build
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix packaging outputs commands

Browse Source 
There were a few issues with the output packaging process that were
found during testing of the general-tests optimization.

First and foremost is that the packaging commands were trying to be
created before the build ran, when the outputs don't exist. I've changed
the logic to just collect the methods themselves which will then be run
during build plan execution after the build has completed.

A few other smaller issues include fixing the path to the soong_zip
binary, incorrect execution of the soong dumpvars command, and not
building the shared libs zip.

Test: atest build_test_suites_test; atest optimized_targets_test
Bug: 358215235
Change-Id: I8a3f54738f8bb5d871aadf7423844076c38b54a6
This commit is contained in:
Luca Farsi
2024-09-17 15:48:11 -07:00
parent 75501177a5
commit 8ea6742d05
4 changed files with 59 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
ci/build_test_suites_test.py
View File

@@ -276,7 +276,8 @@ class BuildPlannerTest(unittest.TestCase):
build_plan = build_planner.create_build_plan()
self.assertEqual(len(build_plan.packaging_commands), 0)
for packaging_command in self.run_packaging_commands(build_plan):
self.assertEqual(len(packaging_command), 0)
def test_build_optimization_on_optimizes_target(self):
build_targets = {'target_1', 'target_2'}
@@ -306,7 +307,7 @@ class BuildPlannerTest(unittest.TestCase):
build_plan = build_planner.create_build_plan()
self.assertIn([f'packaging {optimized_target_name}'], build_plan.packaging_commands)
self.assertIn(packaging_commands, self.run_packaging_commands(build_plan))
def test_individual_build_optimization_off_doesnt_optimize(self):
build_targets = {'target_1', 'target_2'}
@@ -328,7 +329,8 @@ class BuildPlannerTest(unittest.TestCase):
build_plan = build_planner.create_build_plan()
self.assertFalse(build_plan.packaging_commands)
for packaging_command in self.run_packaging_commands(build_plan):
self.assertEqual(len(packaging_command), 0)
def test_target_output_used_target_built(self):
build_target = 'test_target'
@@ -485,6 +487,12 @@ class BuildPlannerTest(unittest.TestCase):
],
}
def run_packaging_commands(self, build_plan: build_test_suites.BuildPlan):
return [
packaging_command_getter()
for packaging_command_getter in build_plan.packaging_commands_getters
]
def wait_until(
condition_function: Callable[[], bool],