From 91c5154a420935e2f055feee247e1f20b1f27235 Mon Sep 17 00:00:00 2001 From: Steven Moreland Date: Wed, 20 Jun 2018 16:01:39 -0700 Subject: [PATCH] Remove vr_hwc from GSI image. Not all phones support the VR, so on phones that don't, the inclusion of vr_hwc is causing VtsHalGraphicsComposerV2_1Target failures. Bug: 109913118 Bug: 111963599 Test: vr_hwc is not on aosp_arm64_ab Change-Id: I803b4dddc5a87e35875992ad9421c644698112f1 Merged-In: I803b4dddc5a87e35875992ad9421c644698112f1 (cherry picked from commit 52971ca09b8539dd03aeb6303053612d9a900bc6) --- CleanSpec.mk | 2 ++ target/product/aosp_arm.mk | 4 ---- target/product/aosp_arm64.mk | 4 ---- target/product/aosp_x86.mk | 4 ---- target/product/aosp_x86_64.mk | 4 ---- target/product/treble_common.mk | 4 ---- 6 files changed, 2 insertions(+), 20 deletions(-) diff --git a/CleanSpec.mk b/CleanSpec.mk index bb3b04f8b9..37c423de42 100644 --- a/CleanSpec.mk +++ b/CleanSpec.mk @@ -491,6 +491,8 @@ $(call add-clean-step, rm -rf $(OUT_DIR)/target/common/obj/APPS/Launcher3_interm # Remove old merged AndroidManifest.xml location $(call add-clean-step, rm -rf $(TARGET_OUT_COMMON_INTERMEDIATES)/APPS/*_intermediates/AndroidManifest.xml) +$(call add-clean-step, find $(PRODUCT_OUT) -type f -name "vr_hwc*" -print0 | xargs -0 rm -f) + # ************************************************ # NEWER CLEAN STEPS MUST BE AT THE END OF THE LIST # ************************************************ diff --git a/target/product/aosp_arm.mk b/target/product/aosp_arm.mk index 30611a0aad..a34998b693 100644 --- a/target/product/aosp_arm.mk +++ b/target/product/aosp_arm.mk @@ -32,10 +32,6 @@ PRODUCT_COPY_FILES += \ prebuilts/qemu-kernel/arm64/3.18/kernel-qemu2:kernel-ranchu-64 \ device/generic/goldfish/fstab.ranchu.arm:$(TARGET_COPY_OUT_VENDOR)/etc/fstab.ranchu -# TODO(b/78308559): includes vr_hwc into GSI before vr_hwc move to vendor -PRODUCT_PACKAGES += \ - vr_hwc - include $(SRC_TARGET_DIR)/product/full.mk # Enable A/B update diff --git a/target/product/aosp_arm64.mk b/target/product/aosp_arm64.mk index 1a4135cb86..faa963781c 100644 --- a/target/product/aosp_arm64.mk +++ b/target/product/aosp_arm64.mk @@ -45,10 +45,6 @@ PRODUCT_COPY_FILES += \ PRODUCT_COPY_FILES += \ system/core/rootdir/init.zygote32_64.rc:root/init.zygote32_64.rc -# TODO(b/78308559): includes vr_hwc into GSI before vr_hwc move to vendor -PRODUCT_PACKAGES += \ - vr_hwc - $(call inherit-product, $(SRC_TARGET_DIR)/product/emulator.mk) $(call inherit-product, $(SRC_TARGET_DIR)/product/core_64_bit.mk) $(call inherit-product, $(SRC_TARGET_DIR)/product/aosp_base_telephony.mk) diff --git a/target/product/aosp_x86.mk b/target/product/aosp_x86.mk index 8e68ce7bdc..cbb678353d 100644 --- a/target/product/aosp_x86.mk +++ b/target/product/aosp_x86.mk @@ -33,10 +33,6 @@ PRODUCT_COPY_FILES += \ device/generic/goldfish/data/etc/encryptionkey.img:encryptionkey.img \ prebuilts/qemu-kernel/x86_64/4.9/kernel-qemu2:kernel-ranchu-64 -# TODO(b/78308559): includes vr_hwc into GSI before vr_hwc move to vendor -PRODUCT_PACKAGES += \ - vr_hwc - include $(SRC_TARGET_DIR)/product/full_x86.mk # Enable A/B update diff --git a/target/product/aosp_x86_64.mk b/target/product/aosp_x86_64.mk index 34328060a1..993aa81257 100644 --- a/target/product/aosp_x86_64.mk +++ b/target/product/aosp_x86_64.mk @@ -42,10 +42,6 @@ PRODUCT_COPY_FILES += \ PRODUCT_COPY_FILES += \ system/core/rootdir/init.zygote32_64.rc:root/init.zygote32_64.rc -# TODO(b/78308559): includes vr_hwc into GSI before vr_hwc move to vendor -PRODUCT_PACKAGES += \ - vr_hwc - $(call inherit-product, $(SRC_TARGET_DIR)/product/emulator.mk) $(call inherit-product, $(SRC_TARGET_DIR)/product/core_64_bit.mk) $(call inherit-product, $(SRC_TARGET_DIR)/product/aosp_base_telephony.mk) diff --git a/target/product/treble_common.mk b/target/product/treble_common.mk index 6cf66affa0..f12df91711 100644 --- a/target/product/treble_common.mk +++ b/target/product/treble_common.mk @@ -62,7 +62,3 @@ PRODUCT_PACKAGES += \ # Support addtional O-MR1 vendor interface PRODUCT_EXTRA_VNDK_VERSIONS := 27 - -# TODO(b/78308559): includes vr_hwc into GSI before vr_hwc move to vendor -PRODUCT_PACKAGES += \ - vr_hwc