StrixOS/build
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Aconfig: sort the parsed flag order in create-cache" into main

Browse Source
This commit is contained in:
Mårten Kongstad
2023-07-20 06:35:02 +00:00
committed by Gerrit Code Review
parent 0ee11559f9 92cf0ec232
commit 9c3502d4b4
3 changed files with 25 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/aconfig/src/commands.rs
View File

@@ -127,6 +127,8 @@ pub fn parse_flags(package: &str, declarations: Vec<Input>, values: Vec<Input>)
} }
} }
// Create a sorted parsed_flags
crate::protos::parsed_flags::sort_parsed_flags(&mut parsed_flags);
crate::protos::parsed_flags::verify_fields(&parsed_flags)?; crate::protos::parsed_flags::verify_fields(&parsed_flags)?;
let mut output = Vec::new(); let mut output = Vec::new();
parsed_flags.write_to_vec(&mut output)?; parsed_flags.write_to_vec(&mut output)?;

4
tools/aconfig/src/protos.rs
View File

@@ -255,6 +255,10 @@ pub mod parsed_flags {
Ok(merged) Ok(merged)
} }
pub fn sort_parsed_flags(pf: &mut ProtoParsedFlags) {
pf.parsed_flag.sort_by_key(create_sorting_key);
}
fn create_sorting_key(pf: &ProtoParsedFlag) -> String { fn create_sorting_key(pf: &ProtoParsedFlag) -> String {
format!("{}.{}", pf.package(), pf.name()) format!("{}.{}", pf.package(), pf.name())
} }

38
tools/aconfig/tests/test.aconfig
View File

@@ -1,24 +1,5 @@
package: "com.android.aconfig.test" package: "com.android.aconfig.test"
# This flag's final value is calculated from:
# - test.aconfig: DISABLED + READ_WRITE (default)
# - first.values: DISABLED + READ_ONLY
flag {
name: "disabled_ro"
namespace: "aconfig_test"
description: "This flag is DISABLED + READ_ONLY"
bug: "123"
}
# This flag's final value is calculated from:
# - test.aconfig: DISABLED + READ_WRITE (default)
flag {
name: "disabled_rw"
namespace: "aconfig_test"
description: "This flag is DISABLED + READ_WRITE"
bug: "456"
}
# This flag's final value is calculated from: # This flag's final value is calculated from:
# - test.aconfig: DISABLED + READ_WRITE (default) # - test.aconfig: DISABLED + READ_WRITE (default)
# - first.values: DISABLED + READ_WRITE # - first.values: DISABLED + READ_WRITE
@@ -40,3 +21,22 @@ flag {
description: "This flag is ENABLED + READ_WRITE" description: "This flag is ENABLED + READ_WRITE"
# no bug field: bug is not mandatory # no bug field: bug is not mandatory
} }
# This flag's final value is calculated from:
# - test.aconfig: DISABLED + READ_WRITE (default)
# - first.values: DISABLED + READ_ONLY
flag {
name: "disabled_ro"
namespace: "aconfig_test"
description: "This flag is DISABLED + READ_ONLY"
bug: "123"
}
# This flag's final value is calculated from:
# - test.aconfig: DISABLED + READ_WRITE (default)
flag {
name: "disabled_rw"
namespace: "aconfig_test"
description: "This flag is DISABLED + READ_WRITE"
bug: "456"
}