From fbb45227c0161146987616175a500d0ca530b79a Mon Sep 17 00:00:00 2001 From: Mark Salyzyn Date: Tue, 8 Sep 2020 07:49:55 -0700 Subject: [PATCH] llkd: moved from optional to required component The Live Lock Killer Daemon (llkd) has provided enough hero moments to improve system stability, by providing actionable collection of data to resolve kernel, and some user space, misbehaviors. It is time to move llkd to a required component. NB: For llkd to be effective at finding real kernel live lock conditions, system requirements are that there are no more un-waited for Zombie processes, and that no kernel drivers use indeterminate periods of uninterruptible sleep. Any kernel and user space tasks that are killed because of suspicious behavior, must themselves have a benefactor to restart them if necessary. If a true live lock is discovered, data will be collected and the kernel will be panic'd to recover from the situation. Signed-off-by: Mark Salyzyn Bug: 164946924 Test: llkd is ever present on a release build. Change-Id: I986a8545252bc5b68d09a6a0f4f506a58998c8a0 --- target/product/base_system.mk | 1 + target/product/generic_system.mk | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/target/product/base_system.mk b/target/product/base_system.mk index 716f00fe7d..cf329772b8 100644 --- a/target/product/base_system.mk +++ b/target/product/base_system.mk @@ -188,6 +188,7 @@ PRODUCT_PACKAGES += \ libwilhelm \ linker \ linkerconfig \ + llkd \ lmkd \ LocalTransport \ locksettings \ diff --git a/target/product/generic_system.mk b/target/product/generic_system.mk index bf74c4a908..81ac60082d 100644 --- a/target/product/generic_system.mk +++ b/target/product/generic_system.mk @@ -39,9 +39,6 @@ PRODUCT_PACKAGES += \ Tag \ TimeZoneUpdater \ -# Binaries -PRODUCT_PACKAGES += llkd - # OTA support PRODUCT_PACKAGES += \ recovery-refresh \