From d98c43c8dda1a56408ae7782f8306872cd24f38a Mon Sep 17 00:00:00 2001 From: Alex Buynytskyy Date: Tue, 11 Apr 2023 16:47:35 +0000 Subject: [PATCH] Script updates. - add a mode to disable finalization steps if they were already merged, - add the extension version into commit message. Bug: 243966946 Test: local run Change-Id: I51505e5d5715b56f3b385d714e1aabaae06f58ed --- tools/finalization/build-step-1-and-2.sh | 16 ++++++++++------ tools/finalization/build-step-1.sh | 7 +++++-- tools/finalization/environment.sh | 8 +++++++- tools/finalization/step-1.sh | 2 +- tools/finalization/update-step-1.sh | 3 +++ tools/finalization/update-step-2.sh | 5 +++++ 6 files changed, 31 insertions(+), 10 deletions(-) mode change 100644 => 100755 tools/finalization/update-step-1.sh diff --git a/tools/finalization/build-step-1-and-2.sh b/tools/finalization/build-step-1-and-2.sh index a5aba0806b..84e2782659 100755 --- a/tools/finalization/build-step-1-and-2.sh +++ b/tools/finalization/build-step-1-and-2.sh @@ -6,14 +6,18 @@ function finalize_main_step12() { local top="$(dirname "$0")"/../../../.. source $top/build/make/tools/finalization/environment.sh - # SDK codename -> int - source $top/build/make/tools/finalization/finalize-aidl-vndk-sdk-resources.sh + if [ "$FINAL_STATE" = "unfinalized" ] ; then + # SDK codename -> int + source $top/build/make/tools/finalization/finalize-aidl-vndk-sdk-resources.sh + fi; - # ADB, Platform/Mainline SDKs build and move to prebuilts - source $top/build/make/tools/finalization/localonly-steps.sh + if [ "$FINAL_STATE" = "unfinalized" ] || [ "$FINAL_STATE" = "sdk" ] ; then + # ADB, Platform/Mainline SDKs build and move to prebuilts + source $top/build/make/tools/finalization/localonly-steps.sh - # REL - source $top/build/make/tools/finalization/finalize-sdk-rel.sh + # REL + source $top/build/make/tools/finalization/finalize-sdk-rel.sh + fi; } finalize_main_step12 diff --git a/tools/finalization/build-step-1.sh b/tools/finalization/build-step-1.sh index a8d590f4a6..3c618fedc5 100755 --- a/tools/finalization/build-step-1.sh +++ b/tools/finalization/build-step-1.sh @@ -6,8 +6,11 @@ function finalize_main_step1() { local top="$(dirname "$0")"/../../../.. source $top/build/make/tools/finalization/environment.sh - # Build finalization artifacts. - source $top/build/make/tools/finalization/finalize-aidl-vndk-sdk-resources.sh + if [ "$FINAL_STATE" = "unfinalized" ] ; then + # Build finalization artifacts. + # source $top/build/make/tools/finalization/finalize-aidl-vndk-sdk-resources.sh + echo "Build finalization artifacts." + fi; } finalize_main_step1 diff --git a/tools/finalization/environment.sh b/tools/finalization/environment.sh index 14951b8628..8c838aa633 100755 --- a/tools/finalization/environment.sh +++ b/tools/finalization/environment.sh @@ -12,4 +12,10 @@ export FINAL_PLATFORM_VERSION='14' export FINAL_BUILD_PREFIX='UP1A' -export FINAL_MAINLINE_EXTENSION='7' \ No newline at end of file +export FINAL_MAINLINE_EXTENSION='7' + +# Options: +# 'unfinalized' - branch is in development state, +# 'sdk' - SDK/API is finalized +# 'rel' - branch is finalized, switched to REL +export FINAL_STATE='unfinalized' diff --git a/tools/finalization/step-1.sh b/tools/finalization/step-1.sh index cf21e4511f..0dd4b3afc3 100755 --- a/tools/finalization/step-1.sh +++ b/tools/finalization/step-1.sh @@ -9,7 +9,7 @@ function commit_step_1_changes() { if [[ $(git status --short) ]]; then repo start "$FINAL_PLATFORM_CODENAME-SDK-Finalization" ; git add -A . ; - git commit -m "$FINAL_PLATFORM_CODENAME is now $FINAL_PLATFORM_SDK_VERSION" \ + git commit -m "$FINAL_PLATFORM_CODENAME is now $FINAL_PLATFORM_SDK_VERSION and extension version $FINAL_MAINLINE_EXTENSION" \ -m "Ignore-AOSP-First: $FINAL_PLATFORM_CODENAME Finalization Bug: $FINAL_BUG_ID Test: build"; diff --git a/tools/finalization/update-step-1.sh b/tools/finalization/update-step-1.sh old mode 100644 new mode 100755 index fd07b7b22a..b469988f2b --- a/tools/finalization/update-step-1.sh +++ b/tools/finalization/update-step-1.sh @@ -1,6 +1,9 @@ #!/bin/bash # Script to perform a 1st step of Android Finalization: API/SDK finalization, update CLs and upload to Gerrit. +# WIP, does not work yet +exit 10 + set -ex function update_step_1_changes() { diff --git a/tools/finalization/update-step-2.sh b/tools/finalization/update-step-2.sh index e65d35a3ee..d2b8592c9d 100755 --- a/tools/finalization/update-step-2.sh +++ b/tools/finalization/update-step-2.sh @@ -1,6 +1,11 @@ #!/bin/bash # Script to perform a 2nd step of Android Finalization: REL finalization, create CLs and upload to Gerrit. +# WIP, does not work yet +exit 10 + +set -ex + function update_step_2_changes() { set +e repo forall -c '\