From b47f7bae6dd804bf9837c224ff842aad34e40794 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Kongstad?= Date: Thu, 7 Mar 2024 13:59:49 +0100 Subject: [PATCH] aflags: remove unnecessary String conversions Reduce the number of allocations by removing superfluous calls to to_string: use a &str where possible, and avoid converting a String to a String. Bug: N/A Test: adb shell aflags list Change-Id: I373018e9ecb393137d11e039ca2c73c0ca5308d7 --- tools/aconfig/aflags/src/main.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/aconfig/aflags/src/main.rs b/tools/aconfig/aflags/src/main.rs index d5704e8301..7ca70a2351 100644 --- a/tools/aconfig/aflags/src/main.rs +++ b/tools/aconfig/aflags/src/main.rs @@ -126,7 +126,7 @@ fn format_flag_row(flag: &Flag, info: &PaddingInfo) -> String { let full_name = flag.qualified_name(); let p0 = info.longest_flag_col + 1; - let val = flag.value.to_string(); + let val = &flag.value; let p1 = info.longest_val_col + 1; let value_picked_from = flag.value_picked_from.to_string(); @@ -161,7 +161,7 @@ fn list() -> Result { let flags = DeviceConfigSource::list_flags()?; let padding_info = PaddingInfo { longest_flag_col: flags.iter().map(|f| f.qualified_name().len()).max().unwrap_or(0), - longest_val_col: flags.iter().map(|f| f.value.to_string().len()).max().unwrap_or(0), + longest_val_col: flags.iter().map(|f| f.value.len()).max().unwrap_or(0), longest_value_picked_from_col: flags .iter() .map(|f| f.value_picked_from.to_string().len())