From 201eb3b6ccbc1658f2147fe7e9ea1b12fd09cfee Mon Sep 17 00:00:00 2001 From: Florian Mayer Date: Wed, 22 Mar 2023 16:14:17 -0700 Subject: [PATCH] Include hwasan lib and runtime on arm64 system images This is needed so we can run hwasan-enabled apps for debugging on normal system images. Bug: 276930343 Change-Id: Ie572d77307e5e6268b851ea5c96aae05d588dae3 --- core/main.mk | 1 + core/product.mk | 1 + target/product/base_system.mk | 8 +++----- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/core/main.mk b/core/main.mk index d0f30a254d..f0a2483d4e 100644 --- a/core/main.mk +++ b/core/main.mk @@ -1252,6 +1252,7 @@ define product-installed-files $(if $(filter tests,$(tags_to_install)),$(call get-product-var,$(1),PRODUCT_PACKAGES_TESTS)) \ $(if $(filter asan,$(tags_to_install)),$(call get-product-var,$(1),PRODUCT_PACKAGES_DEBUG_ASAN)) \ $(if $(filter java_coverage,$(tags_to_install)),$(call get-product-var,$(1),PRODUCT_PACKAGES_DEBUG_JAVA_COVERAGE)) \ + $(if $(filter arm64,$(TARGET_ARCH) $(TARGET_2ND_ARCH)),$(call get-product-var,$(1),PRODUCT_PACKAGES_ARM64)) \ $(call auto-included-modules) \ ) \ $(eval ### Filter out the overridden packages and executables before doing expansion) \ diff --git a/core/product.mk b/core/product.mk index 5f1e14515f..cdc3d091ee 100644 --- a/core/product.mk +++ b/core/product.mk @@ -36,6 +36,7 @@ _product_list_vars += PRODUCT_HOST_PACKAGES _product_list_vars += PRODUCT_PACKAGES _product_list_vars += PRODUCT_PACKAGES_DEBUG _product_list_vars += PRODUCT_PACKAGES_DEBUG_ASAN +_product_list_vars += PRODUCT_PACKAGES_ARM64 # Packages included only for eng/userdebug builds, when building with EMMA_INSTRUMENT=true _product_list_vars += PRODUCT_PACKAGES_DEBUG_JAVA_COVERAGE _product_list_vars += PRODUCT_PACKAGES_ENG diff --git a/target/product/base_system.mk b/target/product/base_system.mk index 94b5c16965..0f5b8a47ff 100644 --- a/target/product/base_system.mk +++ b/target/product/base_system.mk @@ -296,11 +296,9 @@ PRODUCT_PACKAGES += \ system_manifest.xml \ system_compatibility_matrix.xml \ -# HWASAN runtime for SANITIZE_TARGET=hwaddress builds -ifneq (,$(filter hwaddress,$(SANITIZE_TARGET))) - PRODUCT_PACKAGES += \ - libclang_rt.hwasan.bootstrap -endif +PRODUCT_PACKAGES_ARM64 := libclang_rt.hwasan \ + libclang_rt.hwasan.bootstrap \ + libc_hwasan \ # Jacoco agent JARS to be built and installed, if any. ifeq ($(EMMA_INSTRUMENT),true)