From d18e570fbaef9fdc6605ed75960641416a370a79 Mon Sep 17 00:00:00 2001 From: Ying Wang Date: Tue, 11 Feb 2014 17:28:30 -0800 Subject: [PATCH] Clean up dangling module names Those modules have disappeared from the source tree. https://code.google.com/p/android/issues/detail?id=61210 Change-Id: Iab369d2f591f46eb86b9fccf2087515edf974662 --- core/main.mk | 6 +++++- target/product/generic_no_telephony.mk | 8 +------- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/core/main.mk b/core/main.mk index b593acd2cc..de03e31fa4 100644 --- a/core/main.mk +++ b/core/main.mk @@ -698,9 +698,13 @@ ifdef is_sdk_build # Ensure every module listed in PRODUCT_PACKAGES* gets something installed # TODO: Should we do this for all builds and not just the sdk? + dangling_modules := $(foreach m, $(PRODUCTS.$(INTERNAL_PRODUCT).PRODUCT_PACKAGES), \ $(if $(strip $(ALL_MODULES.$(m).INSTALLED)),,\ - $(error $(ALL_MODULES.$(m).MAKEFILE): Module '$(m)' in PRODUCT_PACKAGES has nothing to install!))) + $(eval dangling_modules += $(m)))) + ifneq ($(dangling_modules),) + $(error Module names '$(dangling_modules)' in PRODUCT_PACKAGES has nothing to install!) + endif $(foreach m, $(PRODUCTS.$(INTERNAL_PRODUCT).PRODUCT_PACKAGES_DEBUG), \ $(if $(strip $(ALL_MODULES.$(m).INSTALLED)),,\ $(warning $(ALL_MODULES.$(m).MAKEFILE): Module '$(m)' in PRODUCT_PACKAGES_DEBUG has nothing to install!))) diff --git a/target/product/generic_no_telephony.mk b/target/product/generic_no_telephony.mk index 963d56aa48..04d6e5f90d 100644 --- a/target/product/generic_no_telephony.mk +++ b/target/product/generic_no_telephony.mk @@ -44,18 +44,12 @@ PRODUCT_PACKAGES := \ SystemUI \ TeleService \ CalendarProvider \ - bluetooth-health \ WallpaperCropper PRODUCT_PACKAGES += \ - audio \ clatd \ clatd.conf \ - dhcpcd.conf \ - network \ - pand \ - pppd \ - sdptool + pppd PRODUCT_PACKAGES += \ librs_jni \