From 9ff5fbb02382506ee213910e210d2411c87b1246 Mon Sep 17 00:00:00 2001 From: Christopher Ferris Date: Tue, 23 Apr 2024 17:22:00 -0700 Subject: [PATCH] Add MALLOC_LOW_MEMORY as synonym for MALLOC_SVELTE. The MALLOC_SVELTE variable name is confusing, so add a new variable name called MALLOC_LOW_MEMORY. Still support MALLOC_SVELTE. Also, support the change of Malloc_not_svelte to Malloc_low_memory. Test: Verified scudo config is used by default. Test: Verfified Android GO config uses the jemalloc low memory config. Change-Id: I2606205da746d8ab20e29884c7dcb5a77add51e4 --- core/board_config.mk | 2 +- core/soong_config.mk | 2 +- target/board/ndk/BoardConfig.mk | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/board_config.mk b/core/board_config.mk index 633303f01a..e184601008 100644 --- a/core/board_config.mk +++ b/core/board_config.mk @@ -274,7 +274,7 @@ endif ifneq ($(MALLOC_IMPL),) $(warning *** Unsupported option MALLOC_IMPL defined by board config: $(board_config_mk).) - $(error Use `MALLOC_SVELTE := true` to configure jemalloc for low-memory) + $(error Use `MALLOC_LOW_MEMORY := true` to use low-memory allocator config) endif board_config_mk := diff --git a/core/soong_config.mk b/core/soong_config.mk index 534270e308..acd213c776 100644 --- a/core/soong_config.mk +++ b/core/soong_config.mk @@ -154,7 +154,7 @@ $(call add_json_list, ExtraVndkVersions, $(PRODUCT_EXTRA_VNDK_VE $(call add_json_list, DeviceSystemSdkVersions, $(BOARD_SYSTEMSDK_VERSIONS)) $(call add_json_str, RecoverySnapshotVersion, $(RECOVERY_SNAPSHOT_VERSION)) $(call add_json_list, Platform_systemsdk_versions, $(PLATFORM_SYSTEMSDK_VERSIONS)) -$(call add_json_bool, Malloc_not_svelte, $(call invert_bool,$(filter true,$(MALLOC_SVELTE)))) +$(call add_json_bool, Malloc_low_memory, $(findstring true,$(MALLOC_SVELTE) $(MALLOC_LOW_MEMORY))) $(call add_json_bool, Malloc_zero_contents, $(call invert_bool,$(filter false,$(MALLOC_ZERO_CONTENTS)))) $(call add_json_bool, Malloc_pattern_fill_contents, $(MALLOC_PATTERN_FILL_CONTENTS)) $(call add_json_str, Override_rs_driver, $(OVERRIDE_RS_DRIVER)) diff --git a/target/board/ndk/BoardConfig.mk b/target/board/ndk/BoardConfig.mk index b485f8b79e..d5399b226b 100644 --- a/target/board/ndk/BoardConfig.mk +++ b/target/board/ndk/BoardConfig.mk @@ -15,6 +15,6 @@ TARGET_ARCH_SUITE := ndk -MALLOC_SVELTE := true +MALLOC_LOW_MEMORY := true USE_SAFESTACK := false