From c0d618c3a4f528055567ef99f62cf741f55e61ad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?M=C3=A5rten=20Kongstad?= <amhk@google.com>
Date: Thu, 29 Jun 2023 10:18:20 +0200
Subject: [PATCH] aconfig: fix incorrect check in create_device_config_ident

Use is_valid_name_ident to check the flag name, not
is_valid_package_ident.

Bug: 283910447
Test: atest aconfig.test
Change-Id: I3718e7de565b975a1696190e8effbcb077e5fde2
---
 tools/aconfig/src/codegen.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/aconfig/src/codegen.rs b/tools/aconfig/src/codegen.rs
index e50be0be40..fe52c8df81 100644
--- a/tools/aconfig/src/codegen.rs
+++ b/tools/aconfig/src/codegen.rs
@@ -37,7 +37,7 @@ pub fn is_valid_package_ident(s: &str) -> bool {
 
 pub fn create_device_config_ident(package: &str, flag_name: &str) -> Result<String> {
     ensure!(is_valid_package_ident(package), "bad package");
-    ensure!(is_valid_package_ident(flag_name), "bad flag name");
+    ensure!(is_valid_name_ident(flag_name), "bad flag name");
     Ok(format!("{}.{}", package, flag_name))
 }