From d6d1beb88c846b07ef943645d282cbc86b378370 Mon Sep 17 00:00:00 2001 From: Dan Albert Date: Mon, 23 Mar 2015 16:54:39 -0700 Subject: [PATCH] Run ZipFile.testzip() during zipfile tests. This still doesn't catch the issue that [1] fixes, but it's probably a good idea anyway. [1]: https://android-review.googlesource.com/#/c/143469/ Change-Id: Iaa607ec7450d605b26114bd81ea41a14c6613c0e --- tools/releasetools/test_common.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/releasetools/test_common.py b/tools/releasetools/test_common.py index f163f923b7..5fdc1320c9 100644 --- a/tools/releasetools/test_common.py +++ b/tools/releasetools/test_common.py @@ -62,6 +62,7 @@ class CommonZipTest(unittest.TestCase): new_stat = os.stat(test_file_name) self.assertEqual(int(old_stat.st_mode), int(new_stat.st_mode)) self.assertEqual(int(old_stat.st_mtime), int(new_stat.st_mtime)) + self.assertIsNone(zip_file.testzip()) zip_file.close() zip_file = zipfile.ZipFile(zip_file_name, "r") @@ -71,6 +72,7 @@ class CommonZipTest(unittest.TestCase): mode = (info.external_attr >> 16) & 0o777 self.assertEqual(mode, expected_mode) self.assertEqual(zip_file.read(arcname), contents) + self.assertIsNone(zip_file.testzip()) finally: os.remove(test_file_name) os.remove(zip_file_name)