From 771a201f3d74116a802f37757555434eef7dab35 Mon Sep 17 00:00:00 2001 From: Paul Duffin Date: Fri, 3 May 2024 12:13:32 +0100 Subject: [PATCH] Use complete api-versions.xml for module-lib and system-server Previously, the check-flagged-apis.sh script used `api-versions.xml` for `module-lib` and `system-server` which did not include the latest up-to-date information about updatable modules or historical information about sdk extensions which lead to false positives for APIs from those updatable modules. This changes switches to use the `api-versions.xml` produced by the new `api_versions_*_complete` modules which does include that information. Bug: 337836752 Test: Run script before and after applying this change to make sure that flagged APIs from updatable modules are no longer reported as missing. Change-Id: If09e89a4595a19d9f00390fb5fbd24330ec11be5 --- tools/check-flagged-apis/check-flagged-apis.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/check-flagged-apis/check-flagged-apis.sh b/tools/check-flagged-apis/check-flagged-apis.sh index d93d04febc..d9934a11fe 100755 --- a/tools/check-flagged-apis/check-flagged-apis.sh +++ b/tools/check-flagged-apis/check-flagged-apis.sh @@ -22,8 +22,8 @@ require_top PUBLIC_XML_VERSIONS=out/target/common/obj/PACKAGING/api_versions_public_generated-api-versions.xml SYSTEM_XML_VERSIONS=out/target/common/obj/PACKAGING/api_versions_system_generated-api-versions.xml -SYSTEM_SERVER_XML_VERSONS=out/target/common/obj/PACKAGING/api_versions_system_server_generated-api-versions.xml -MODULE_LIB_XML_VERSIONS=out/target/common/obj/PACKAGING/api_versions_module_lib_generated-api-versions.xml +SYSTEM_SERVER_XML_VERSONS=out/target/common/obj/PACKAGING/api_versions_system_server_complete_generated-api-versions.xml +MODULE_LIB_XML_VERSIONS=out/target/common/obj/PACKAGING/api_versions_module_lib_complete_generated-api-versions.xml function m() { $(gettop)/build/soong/soong_ui.bash --build-mode --all-modules --dir="$(pwd)" "$@"