From c9e72668a0c11cca24f79fe116686aa61a1be7de Mon Sep 17 00:00:00 2001 From: Trevor Radcliffe Date: Mon, 15 Aug 2022 20:08:20 +0000 Subject: [PATCH] Add note to Changes.md about sysprop changes Since it's no longer allowed to depend directly on a sysprop_library module from a cc module, we should make this known to other engineers. Bug: 226199990 Test: N/A Change-Id: I3a66984abc3ab7b369870c8041a08d788d66b15f --- Changes.md | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/Changes.md b/Changes.md index a03a48c554..e3ec0f8bcc 100644 --- a/Changes.md +++ b/Changes.md @@ -1,5 +1,31 @@ # Build System Changes for Android.mk Writers +## Stop referencing sysprop_library directly from cc modules + +For the migration to Bazel, we are no longer mapping sysprop_library targets +to their generated `cc_library` counterparts when dependning on them from a +cc module. Instead, directly depend on the generated module by prefixing the +module name with `lib`. For example, depending on the following module: + +``` +sysprop_library { + name: "foo", + srcs: ["foo.sysprop"], +} +``` + +from a module named `bar` can be done like so: + +``` +cc_library { + name: "bar", + srcs: ["bar.cc"], + deps: ["libfoo"], +} +``` + +Failure to do this will result in an error about a missing variant. + ## Gensrcs starts disallowing depfile property To migrate all gensrcs to Bazel, we are restricting the use of depfile property