StrixOS/build
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add PROP_NAME_MAX validation

Browse Source 
Change-Id: I49179c83ae163de6f6fb398c5de60c5d296ca009
This commit is contained in:
Brian Carlstrom
2014-07-29 16:08:25 -07:00
parent ecc4267564
commit dad2ab4df4
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tools/post_process_props.py
View File

@@ -16,9 +16,10 @@
import sys import sys
# See PROP_VALUE_MAX system_properties.h. # See PROP_NAME_MAX and PROP_VALUE_MAX system_properties.h.
# PROP_VALUE_MAX in system_properties.h includes the termination NUL, # The constants in system_properties.h includes the termination NUL,
# so we decrease it by 1 here. # so we decrease the values by 1 here.
PROP_NAME_MAX = 31
PROP_VALUE_MAX = 91 PROP_VALUE_MAX = 91
# Put the modifications that you need to make into the /system/build.prop into this # Put the modifications that you need to make into the /system/build.prop into this
@@ -56,6 +57,11 @@ def validate(prop):
"").startswith("eng") "").startswith("eng")
for key, value in buildprops.iteritems(): for key, value in buildprops.iteritems():
# Check build properties' length. # Check build properties' length.
if len(key) > PROP_NAME_MAX:
check_pass = False
sys.stderr.write("error: %s cannot exceed %d bytes: " %
(key, PROP_NAME_MAX))
sys.stderr.write("%s (%d)\n" % (key, len(key)))
if len(value) > PROP_VALUE_MAX: if len(value) > PROP_VALUE_MAX:
# If dev build, show a warning message, otherwise fail the # If dev build, show a warning message, otherwise fail the
# build with error message # build with error message