diff --git a/core/Makefile b/core/Makefile index 7900263f00..8602163a27 100644 --- a/core/Makefile +++ b/core/Makefile @@ -753,6 +753,12 @@ event-log-tags: $(event_log_tags_file) ALL_DEFAULT_INSTALLED_MODULES += $(event_log_tags_file) +# Initialize INSTALLED_FILES_OUTSIDE_IMAGES with the list of all device files, +# files installed in images will be filtered out later. +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out \ + $(PRODUCT_OUT)/apex/% \ + $(PRODUCT_OUT)/testcases/%, \ + $(filter $(PRODUCT_OUT)/%,$(ALL_DEFAULT_INSTALLED_MODULES))) # ################################################################# # Targets for boot/OS images @@ -785,10 +791,11 @@ endif # ----------------------------------------------------------------- # the root dir +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_ROOT_OUT)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) INTERNAL_ROOT_FILES := $(filter $(TARGET_ROOT_OUT)/%, \ - $(ALL_GENERATED_SOURCES) \ $(ALL_DEFAULT_INSTALLED_MODULES)) + INSTALLED_FILES_FILE_ROOT := $(PRODUCT_OUT)/installed-files-root.txt INSTALLED_FILES_JSON_ROOT := $(INSTALLED_FILES_FILE_ROOT:.txt=.json) $(INSTALLED_FILES_FILE_ROOT): .KATI_IMPLICIT_OUTPUTS := $(INSTALLED_FILES_JSON_ROOT) @@ -818,9 +825,9 @@ endif # ----------------------------------------------------------------- # the ramdisk +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_RAMDISK_OUT)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) ifdef BUILDING_RAMDISK_IMAGE INTERNAL_RAMDISK_FILES := $(filter $(TARGET_RAMDISK_OUT)/%, \ - $(ALL_GENERATED_SOURCES) \ $(ALL_DEFAULT_INSTALLED_MODULES)) INSTALLED_FILES_FILE_RAMDISK := $(PRODUCT_OUT)/installed-files-ramdisk.txt @@ -1247,6 +1254,7 @@ endif # BUILDING_INIT_BOOT_IMAGE is not true # ----------------------------------------------------------------- # vendor boot image +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_VENDOR_RAMDISK_OUT)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) ifeq ($(BUILDING_VENDOR_BOOT_IMAGE),true) ifeq ($(PRODUCT_SUPPORTS_VERITY),true) @@ -1254,7 +1262,6 @@ ifeq ($(PRODUCT_SUPPORTS_VERITY),true) endif INTERNAL_VENDOR_RAMDISK_FILES := $(filter $(TARGET_VENDOR_RAMDISK_OUT)/%, \ - $(ALL_GENERATED_SOURCES) \ $(ALL_DEFAULT_INSTALLED_MODULES)) INTERNAL_VENDOR_RAMDISK_TARGET := $(call intermediates-dir-for,PACKAGING,vendor_boot)/vendor_ramdisk.cpio$(RAMDISK_EXT) @@ -2048,6 +2055,7 @@ endef # Recovery image # Recovery image exists if we are building recovery, or building recovery as boot. +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_RECOVERY_OUT)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) ifdef BUILDING_RECOVERY_IMAGE INTERNAL_RECOVERYIMAGE_FILES := $(filter $(TARGET_RECOVERY_OUT)/%, \ @@ -2519,10 +2527,10 @@ endif # ----------------------------------------------------------------- # Build debug ramdisk and debug boot image. +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_DEBUG_RAMDISK_OUT)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) ifneq ($(BUILDING_DEBUG_BOOT_IMAGE)$(BUILDING_DEBUG_VENDOR_BOOT_IMAGE),) INTERNAL_DEBUG_RAMDISK_FILES := $(filter $(TARGET_DEBUG_RAMDISK_OUT)/%, \ - $(ALL_GENERATED_SOURCES) \ $(ALL_DEFAULT_INSTALLED_MODULES)) # Directories to be picked into the debug ramdisk. @@ -2657,10 +2665,10 @@ endif # BUILDING_DEBUG_BOOT_IMAGE # ----------------------------------------------------------------- # vendor debug ramdisk # Combines vendor ramdisk files and debug ramdisk files to build the vendor debug ramdisk. +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_VENDOR_DEBUG_RAMDISK_OUT)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) ifdef BUILDING_DEBUG_VENDOR_BOOT_IMAGE INTERNAL_VENDOR_DEBUG_RAMDISK_FILES := $(filter $(TARGET_VENDOR_DEBUG_RAMDISK_OUT)/%, \ - $(ALL_GENERATED_SOURCES) \ $(ALL_DEFAULT_INSTALLED_MODULES)) # The debug vendor ramdisk combines vendor ramdisk and debug ramdisk. @@ -2769,9 +2777,9 @@ endif $(call declare-1p-target,$(INTERNAL_TEST_HARNESS_RAMDISK_ADB_DEBUG_PROP_TARGET)) +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_TEST_HARNESS_RAMDISK_OUT)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) INTERNAL_TEST_HARNESS_RAMDISK_FILES := $(filter $(TARGET_TEST_HARNESS_RAMDISK_OUT)/%, \ $(INTERNAL_TEST_HARNESS_RAMDISK_ADB_DEBUG_PROP_TARGET) \ - $(ALL_GENERATED_SOURCES) \ $(ALL_DEFAULT_INSTALLED_MODULES)) # The order is important here. The test harness ramdisk staging directory has to @@ -2947,7 +2955,7 @@ fsverity-metadata-targets := $(sort $(filter \ $(TARGET_OUT)/etc/dirty-image-objects \ $(TARGET_OUT)/etc/preloaded-classes \ $(TARGET_OUT)/etc/classpaths/%.pb, \ - $(ALL_GENERATED_SOURCES) $(ALL_DEFAULT_INSTALLED_MODULES))) + $(ALL_DEFAULT_INSTALLED_MODULES))) define fsverity-generate-metadata $(1).fsv_meta: PRIVATE_SRC := $(1) @@ -2993,8 +3001,8 @@ ALL_DEFAULT_INSTALLED_MODULES += $(FSVERITY_APK_OUT) endif # PRODUCT_SYSTEM_FSVERITY_GENERATE_METADATA +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_OUT)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) INTERNAL_SYSTEMIMAGE_FILES := $(sort $(filter $(TARGET_OUT)/%, \ - $(ALL_GENERATED_SOURCES) \ $(ALL_DEFAULT_INSTALLED_MODULES))) # Create symlink /system/vendor to /vendor if necessary. @@ -3180,6 +3188,7 @@ platform-java: # ----------------------------------------------------------------- # data partition image +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_OUT_DATA)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) INTERNAL_USERDATAIMAGE_FILES := \ $(filter $(TARGET_OUT_DATA)/%,$(ALL_DEFAULT_INSTALLED_MODULES)) @@ -3273,6 +3282,7 @@ endif # BOARD_BPT_INPUT_FILES # ----------------------------------------------------------------- # cache partition image +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_OUT_CACHE)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) ifdef BUILDING_CACHE_IMAGE INTERNAL_CACHEIMAGE_FILES := \ $(filter $(TARGET_OUT_CACHE)/%,$(ALL_DEFAULT_INSTALLED_MODULES)) @@ -3314,6 +3324,7 @@ endif # BUILDING_CACHE_IMAGE # ----------------------------------------------------------------- # system_other partition image +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_OUT_SYSTEM_OTHER)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) ifdef BUILDING_SYSTEM_OTHER_IMAGE ifeq ($(BOARD_USES_SYSTEM_OTHER_ODEX),true) # Marker file to identify that odex files are installed @@ -3394,6 +3405,7 @@ endif # BUILDING_SYSTEM_OTHER_IMAGE # ----------------------------------------------------------------- # vendor partition image +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_OUT_VENDOR)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) ifdef BUILDING_VENDOR_IMAGE INTERNAL_VENDORIMAGE_FILES := \ $(filter $(TARGET_OUT_VENDOR)/%,\ @@ -3477,6 +3489,7 @@ endif # ----------------------------------------------------------------- # product partition image +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_OUT_PRODUCT)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) ifdef BUILDING_PRODUCT_IMAGE INTERNAL_PRODUCTIMAGE_FILES := \ $(filter $(TARGET_OUT_PRODUCT)/%,\ @@ -3535,6 +3548,7 @@ endif # ----------------------------------------------------------------- # system_ext partition image +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_OUT_SYSTEM_EXT)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) ifdef BUILDING_SYSTEM_EXT_IMAGE INTERNAL_SYSTEM_EXTIMAGE_FILES := \ $(filter $(TARGET_OUT_SYSTEM_EXT)/%,\ @@ -3595,6 +3609,7 @@ endif # ----------------------------------------------------------------- # odm partition image +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_OUT_ODM)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) ifdef BUILDING_ODM_IMAGE INTERNAL_ODMIMAGE_FILES := \ $(filter $(TARGET_OUT_ODM)/%,\ @@ -3672,6 +3687,7 @@ endif # ----------------------------------------------------------------- # vendor_dlkm partition image +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_OUT_VENDOR_DLKM)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) ifdef BUILDING_VENDOR_DLKM_IMAGE INTERNAL_VENDOR_DLKMIMAGE_FILES := \ $(filter $(TARGET_OUT_VENDOR_DLKM)/%,\ @@ -3731,6 +3747,7 @@ endif # ----------------------------------------------------------------- # odm_dlkm partition image +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_OUT_ODM_DLKM)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) ifdef BUILDING_ODM_DLKM_IMAGE INTERNAL_ODM_DLKMIMAGE_FILES := \ $(filter $(TARGET_OUT_ODM_DLKM)/%,\ @@ -3791,6 +3808,7 @@ endif # ----------------------------------------------------------------- # system_dlkm partition image +INSTALLED_FILES_OUTSIDE_IMAGES := $(filter-out $(TARGET_OUT_SYSTEM_DLKM)/%, $(INSTALLED_FILES_OUTSIDE_IMAGES)) ifdef BUILDING_SYSTEM_DLKM_IMAGE INTERNAL_SYSTEM_DLKMIMAGE_FILES := \ diff --git a/core/binary.mk b/core/binary.mk index 94e3a0fecb..665270e30a 100644 --- a/core/binary.mk +++ b/core/binary.mk @@ -573,8 +573,6 @@ my_generated_sources := $(patsubst $(generated_sources_dir)/%,$(intermediates)/% # the dependencies. my_gen_src_files := $(filter %.c %$(LOCAL_CPP_EXTENSION) %.S %.s,$(my_generated_sources)) -ALL_GENERATED_SOURCES += $(my_generated_sources) - #################################################### ## Compile RenderScript with reflected C++ #################################################### diff --git a/core/config.mk b/core/config.mk index 5ef9211846..48aa724b32 100644 --- a/core/config.mk +++ b/core/config.mk @@ -159,6 +159,8 @@ $(KATI_deprecated_var BOARD_PLAT_PUBLIC_SEPOLICY_DIR,Use SYSTEM_EXT_PUBLIC_SEPOL $(KATI_deprecated_var BOARD_PLAT_PRIVATE_SEPOLICY_DIR,Use SYSTEM_EXT_PRIVATE_SEPOLICY_DIRS instead) $(KATI_obsolete_var TARGET_NO_VENDOR_BOOT,Use PRODUCT_BUILD_VENDOR_BOOT_IMAGE instead) $(KATI_obsolete_var PRODUCT_CHECK_ELF_FILES,Use BUILD_BROKEN_PREBUILT_ELF_FILES instead) +$(KATI_obsolete_var ALL_GENERATED_SOURCES,ALL_GENERATED_SOURCES is no longer used) +$(KATI_obsolete_var ALL_ORIGINAL_DYNAMIC_BINARIES,ALL_ORIGINAL_DYNAMIC_BINARIES is no longer used) # Used to force goals to build. Only use for conditionally defined goals. .PHONY: FORCE diff --git a/core/definitions.mk b/core/definitions.mk index 1c9ebad78b..4e5c7885d6 100644 --- a/core/definitions.mk +++ b/core/definitions.mk @@ -59,16 +59,10 @@ ALL_MODULE_TAGS:= # its sub-variables.) ALL_MODULE_NAME_TAGS:= -# Full path to all files that are made by some tool -ALL_GENERATED_SOURCES:= - # Full path to all asm, C, C++, lex and yacc generated C files. # These all have an order-only dependency on the copied headers ALL_C_CPP_ETC_OBJECTS:= -# The list of dynamic binaries that haven't been stripped/compressed/etc. -ALL_ORIGINAL_DYNAMIC_BINARIES:= - # These files go into the SDK ALL_SDK_FILES:= diff --git a/core/dynamic_binary.mk b/core/dynamic_binary.mk index a9b3720a68..52d7ddc18f 100644 --- a/core/dynamic_binary.mk +++ b/core/dynamic_binary.mk @@ -25,13 +25,8 @@ intermediates := $(call local-intermediates-dir,,$(LOCAL_2ND_ARCH_VAR_PREFIX)) # The includer of this file will define a rule to build this target. linked_module := $(intermediates)/LINKED/$(notdir $(my_installed_module_stem)) -ALL_ORIGINAL_DYNAMIC_BINARIES += $(linked_module) - -# Because TARGET_SYMBOL_FILTER_FILE depends on ALL_ORIGINAL_DYNAMIC_BINARIES, -# the linked_module rules won't necessarily inherit the PRIVATE_ -# variables from LOCAL_BUILT_MODULE. This tells binary.make to explicitly -# define the PRIVATE_ variables for linked_module as well as for -# LOCAL_BUILT_MODULE. +# This tells binary.make to explicitly define the PRIVATE_ variables for +# linked_module as well as for LOCAL_BUILT_MODULE. LOCAL_INTERMEDIATE_TARGETS := $(linked_module) ################################### diff --git a/core/main.mk b/core/main.mk index 0ca5e5202a..72958dab2d 100644 --- a/core/main.mk +++ b/core/main.mk @@ -1634,6 +1634,7 @@ vbmetavendorimage: $(INSTALLED_VBMETA_VENDORIMAGE_TARGET) # perform a full system build (either unbundled or not). .PHONY: droidcore-unbundled droidcore-unbundled: $(filter $(HOST_OUT_ROOT)/%,$(modules_to_install)) \ + $(INSTALLED_FILES_OUTSIDE_IMAGES) \ $(INSTALLED_SYSTEMIMAGE_TARGET) \ $(INSTALLED_RAMDISK_TARGET) \ $(INSTALLED_BOOTIMAGE_TARGET) \