releasetools: Use java_path in sign_target_files_apks.py.
Prior to this CL, it was calling the hard-coded "java" although it was accepting a "--java_path" option. Also switch OPTIONS.java_args from string to list. Otherwise it won't work when providing multiple args. Bug: 32737832 Test: Specify "--java_path=" and "--java_args" when invoking sign_target_files_apks.py with "-v". Check the commands being called. Change-Id: Id7ef98e778646d532027434de7fba9b7a104dbd0
This commit is contained in:
@@ -46,7 +46,7 @@ class Options(object):
|
||||
self.signapk_shared_library_path = "lib64" # Relative to search_path
|
||||
self.extra_signapk_args = []
|
||||
self.java_path = "java" # Use the one on the path by default.
|
||||
self.java_args = "-Xmx2048m" # JVM Args
|
||||
self.java_args = ["-Xmx2048m"] # The default JVM args.
|
||||
self.public_key_suffix = ".x509.pem"
|
||||
self.private_key_suffix = ".pk8"
|
||||
# use otatools built boot_signer by default
|
||||
@@ -719,11 +719,10 @@ def SignFile(input_name, output_name, key, password, min_api_level=None,
|
||||
java_library_path = os.path.join(
|
||||
OPTIONS.search_path, OPTIONS.signapk_shared_library_path)
|
||||
|
||||
cmd = [OPTIONS.java_path, OPTIONS.java_args,
|
||||
"-Djava.library.path=" + java_library_path,
|
||||
"-jar",
|
||||
os.path.join(OPTIONS.search_path, OPTIONS.signapk_path)]
|
||||
cmd.extend(OPTIONS.extra_signapk_args)
|
||||
cmd = ([OPTIONS.java_path] + OPTIONS.java_args +
|
||||
["-Djava.library.path=" + java_library_path,
|
||||
"-jar", os.path.join(OPTIONS.search_path, OPTIONS.signapk_path)] +
|
||||
OPTIONS.extra_signapk_args)
|
||||
if whole_file:
|
||||
cmd.append("-w")
|
||||
|
||||
@@ -875,7 +874,7 @@ def ParseOptions(argv,
|
||||
elif o in ("--java_path",):
|
||||
OPTIONS.java_path = a
|
||||
elif o in ("--java_args",):
|
||||
OPTIONS.java_args = a
|
||||
OPTIONS.java_args = shlex.split(a)
|
||||
elif o in ("--public_key_suffix",):
|
||||
OPTIONS.public_key_suffix = a
|
||||
elif o in ("--private_key_suffix",):
|
||||
|
Reference in New Issue
Block a user