StrixOS/build
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Greater-than zero is more idiomatic.

Browse Source 
Test: m all
Change-Id: I6000d937b98c84226a347b69c69b333a15beb355
This commit is contained in:
Bob Badour
2022-02-09 15:56:59 -08:00
parent bcb81e74fe
commit e9b38c175a
6 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tools/compliance/cmd/htmlnotice/htmlnotice.go
View File

@@ -204,17 +204,17 @@ func htmlNotice(ctx *context, files ...string) error {
fmt.Fprintln(ctx.stdout, "li { padding-left: 1em; }")
fmt.Fprintln(ctx.stdout, ".file-list { margin-left: 1em; }")
fmt.Fprintln(ctx.stdout, "</style>")
if 0 < len(ctx.title) {
if len(ctx.title) > 0 {
fmt.Fprintf(ctx.stdout, "<title>%s</title>\n", html.EscapeString(ctx.title))
} else if 0 < len(ctx.product) {
} else if len(ctx.product) > 0 {
fmt.Fprintf(ctx.stdout, "<title>%s</title>\n", html.EscapeString(ctx.product))
}
fmt.Fprintln(ctx.stdout, "</head>")
fmt.Fprintln(ctx.stdout, "<body>")
if 0 < len(ctx.title) {
if len(ctx.title) > 0 {
fmt.Fprintf(ctx.stdout, " <h1>%s</h1>\n", html.EscapeString(ctx.title))
} else if 0 < len(ctx.product) {
} else if len(ctx.product) > 0 {
fmt.Fprintf(ctx.stdout, " <h1>%s</h1>\n", html.EscapeString(ctx.product))
}
ids := make(map[string]string)

2
tools/compliance/cmd/htmlnotice/htmlnotice_test.go
View File

@@ -678,7 +678,7 @@ func Test(t *testing.T) {
}
if !inBody {
if expectTitle {
if tl := checkTitle(line); 0 < len(tl) {
if tl := checkTitle(line); len(tl) > 0 {
if tl != ttle.t {
t.Errorf("htmlnotice: unexpected title: got %q, want %q", tl, ttle.t)
}