From 431f44a31481014e339086a34c7369813d1fb8a7 Mon Sep 17 00:00:00 2001 From: Ted Bauer Date: Fri, 13 Sep 2024 20:59:34 +0000 Subject: [PATCH] Don't show staged value if flag is RO Bug: 324436145 Change-Id: I493421f29d6e7f5e844dd47cc6417b3d5fe9cdbb Test: m aflags && aflags list --- tools/aconfig/aflags/src/main.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/aconfig/aflags/src/main.rs b/tools/aconfig/aflags/src/main.rs index a726cc0369..07b7243ab4 100644 --- a/tools/aconfig/aflags/src/main.rs +++ b/tools/aconfig/aflags/src/main.rs @@ -116,9 +116,10 @@ impl Flag { } fn display_staged_value(&self) -> String { - match self.staged_value { - Some(v) => format!("(->{})", v), - None => "-".to_string(), + match (&self.permission, self.staged_value) { + (FlagPermission::ReadOnly, _) => "-".to_string(), + (FlagPermission::ReadWrite, None) => "-".to_string(), + (FlagPermission::ReadWrite, Some(v)) => format!("(->{})", v), } } }