From b97d8c78e2c8ca6978d1db19c3c07e4eb114bade Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Sat, 21 Feb 2015 11:01:11 -0800 Subject: [PATCH] Turn on -Werror=implicit-function-declaration for x86-64. Implicit function declarations are much more dangerous on LP64 because sizeof(int) != sizeof(void*), so any function that returns a pointer will lose its top bits, leading to relatively hard to debug crashes. Change-Id: Ib2570326dde1b1cde09c63c9b4c973d741528ee2 --- core/combo/TARGET_linux-x86_64.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/core/combo/TARGET_linux-x86_64.mk b/core/combo/TARGET_linux-x86_64.mk index d92e974a3c..046a42bb56 100644 --- a/core/combo/TARGET_linux-x86_64.mk +++ b/core/combo/TARGET_linux-x86_64.mk @@ -97,6 +97,7 @@ TARGET_GLOBAL_CFLAGS += \ TARGET_GLOBAL_CFLAGS += \ -Werror=pointer-to-int-cast \ -Werror=int-to-pointer-cast \ + -Werror=implicit-function-declaration \ android_config_h := $(call select-android-config-h,target_linux-x86) TARGET_ANDROID_CONFIG_CFLAGS := -include $(android_config_h) -I $(dir $(android_config_h))