Commit Graph

85392 Commits

Author SHA1 Message Date
Dennis Shen
8d544f7439 cpp codegen redesign, unit test support
cpp codegen iteration 2, based on discussions with three internal teams
that use c++. Refer to the design doc "aconfig c++ codegen" for detailed
design. At a high level, we generate two sets of code artifacts with the
same signatured api: one for production that without any local flag
override capability, one for unit test that allows local flag overrides.
It supports static methods style interface as well as injection pattern.

Refer to the test points in the codegen_cpp.rs for examples of generated
code.

for production target codegen: aconfig create-cpp-lib --cache <cache> --out <out dir>
for test target codegen: aconfig create-cpp-lib --cache <cache> --out
<out dir> --mode test

Bug: b/279483801
Test: atest aconfig.test
Change-Id: I92fefb9623d5435525339a74f57bbd36d0afef08
2023-07-05 14:05:44 +00:00
Wenshan Fu
89467c3109 aconfig: create java libraries for aconfig proto
Host side test infra needs the library to consume the dumped flags info
generated by aconfig.

Test: m libaconfig_java_proto_lite libaconfig_java_proto_full
Bug: 289906970
Change-Id: I9891cb8445b90f7269e0c679ceaae6bc102bbb0c
2023-07-05 13:57:19 +00:00
Rashid Zaman
c4624460ca Quote pattern in 'find' command used to generate modules.load
When a kernel module archive is specified via
BOARD_*_KERNEL_MODULES_ARCHIVE an unquoted wildcard pattern in the
'find' command used to find modules to add to modules.load can result
in a build failure due to shell expansion. Fix this by quoting the
pattern so that kernel modules in $ANDROID_BUILD_TOP don't cause
unexpected build failures.

Bug: 289887845
Test: Define BOARD_VENDOR_KERNEL_MODULES_ARCHIVE for
aosp_cf_x86_64_phone, touch foo.ko &&
lunch aosp_cf_x86_64_phone-userdebug && m succeeds.

Change-Id: I8122afc6bbbb5df6e3b11922b2be38129addeda0
Signed-off-by: Rashid Zaman <rashidz@meta.com>
2023-07-04 23:16:34 -07:00
Kangping Dong
d1ef7f4487 Merge "add com.android.threadnetwork to base_system.mk" am: 235662f15a am: a0e4fab6f0
Original change: https://android-review.googlesource.com/c/platform/build/+/2645819

Change-Id: I15346864cdf2f8a08406cbb49aa6e9771dd450c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-04 03:25:09 +00:00
Kangping Dong
a0e4fab6f0 Merge "add com.android.threadnetwork to base_system.mk" am: 235662f15a
Original change: https://android-review.googlesource.com/c/platform/build/+/2645819

Change-Id: Iaadb738d8b3f694629041cf36f8f50ff148ad6d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-04 02:26:17 +00:00
Wenshan Fu
a49ad1b8df Merge "Create the TEST_MAPPING file" am: e0b709b9a6 am: 5a80e2617d
Original change: https://android-review.googlesource.com/c/platform/build/+/2643392

Change-Id: Ia69296a4c9004d7ca24123f53fdcf51e59c66ff5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-04 01:59:38 +00:00
Kangping Dong
235662f15a Merge "add com.android.threadnetwork to base_system.mk" 2023-07-04 01:52:46 +00:00
Wenshan Fu
5a80e2617d Merge "Create the TEST_MAPPING file" am: e0b709b9a6
Original change: https://android-review.googlesource.com/c/platform/build/+/2643392

Change-Id: I4d53145ffa9395f60f1d4e751de2acb03f01922b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-04 01:22:48 +00:00
Wenshan Fu
e0b709b9a6 Merge "Create the TEST_MAPPING file" 2023-07-04 00:44:05 +00:00
Treehugger Robot
4b921576ff Merge "Adds Window Extensions to GSI" am: f81a3793f4 am: 4db386ca09
Original change: https://android-review.googlesource.com/c/platform/build/+/2648120

Change-Id: I740715ce4b61480fa7470e9e14c8946044bcfee8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-03 12:20:27 +00:00
Treehugger Robot
4db386ca09 Merge "Adds Window Extensions to GSI" am: f81a3793f4
Original change: https://android-review.googlesource.com/c/platform/build/+/2648120

Change-Id: Ieb1ce72bbd5e9ac29384f7b3248a76b6b375c454
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-03 11:43:46 +00:00
Treehugger Robot
f81a3793f4 Merge "Adds Window Extensions to GSI" 2023-07-03 11:00:58 +00:00
Kangping Dong
286e55ad94 add com.android.threadnetwork to base_system.mk
Bug: 262683651
Test: atest CtsSystemApiSignatureTestCases
Merged-In: Iefe7fa4c74ab9608faeb9d64e75c054e9b90afdb
Change-Id: Id4f34b70aee2277236762092f8a40254963a6b4f
2023-07-03 17:24:05 +08:00
Louis Chang
886ad7a862 Adds Window Extensions to GSI
... in order to have window extension library included
especially on large screen devices.

Bug: 288624195
Test: atest SdkAvailabilityTest
Ignore-AOSP-First: Future release
Change-Id: I8d347917f002cefb4f297930370ac7ae847f4731
2023-07-03 13:29:20 +08:00
Treehugger Robot
571c6284fa Merge "Enable CFI for the whole Bluetooth repo and not just system" am: 03bc41cae7 am: 3f10714916
Original change: https://android-review.googlesource.com/c/platform/build/+/2645203

Change-Id: I4e1437fcf782fcabddb60673578589a5c40aedd1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:27:30 +00:00
Treehugger Robot
3f10714916 Merge "Enable CFI for the whole Bluetooth repo and not just system" am: 03bc41cae7
Original change: https://android-review.googlesource.com/c/platform/build/+/2645203

Change-Id: Ie401127fb9d499e4a75f25f18e61e0704f8bd605
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 22:47:39 +00:00
Treehugger Robot
03bc41cae7 Merge "Enable CFI for the whole Bluetooth repo and not just system" 2023-06-30 22:04:30 +00:00
Ulya Trofimovich
975e0ef22b Merge "Add riscv64 banchan target." am: 40b9ac7ee5 am: 6270916eff
Original change: https://android-review.googlesource.com/c/platform/build/+/2622111

Change-Id: I2453778f510e523fd1baa3a88755e43103b36dec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 14:50:38 +00:00
Zhi Dou
45842104d2 Merge changes I4bf1d3ba,I33605054 am: 7734879e69 am: e911b7cf7c
Original change: https://android-review.googlesource.com/c/platform/build/+/2643057

Change-Id: I619aea6db601b5ad2885911122bb96bc3e4358ec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 14:49:49 +00:00
Ulya Trofimovich
6270916eff Merge "Add riscv64 banchan target." am: 40b9ac7ee5
Original change: https://android-review.googlesource.com/c/platform/build/+/2622111

Change-Id: Id99f370918459dd7e4cc445b419c56c5017ae3e2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 14:14:10 +00:00
Zhi Dou
e911b7cf7c Merge changes I4bf1d3ba,I33605054 am: 7734879e69
Original change: https://android-review.googlesource.com/c/platform/build/+/2643057

Change-Id: I59851f958affe18fe8a9a90a9515f60d33b8d238
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 14:13:44 +00:00
Ulya Trofimovich
40b9ac7ee5 Merge "Add riscv64 banchan target." 2023-06-30 14:05:16 +00:00
Zhi Dou
7734879e69 Merge changes I4bf1d3ba,I33605054
* changes:
  aconfig: Add resetAll method to test mode FeatureFlagsImpl
  aconfig: remove extra new lines and spaces in generated java code
2023-06-30 13:23:28 +00:00
Treehugger Robot
4c589c7216 Merge "Add --classes optional flag in list_files" am: 32efc846f5 am: 46c121d2a7
Original change: https://android-review.googlesource.com/c/platform/build/+/2635796

Change-Id: I9e4c89600cabf98b4fc7d7779af286f0ba41e89d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 10:59:26 +00:00
Treehugger Robot
46c121d2a7 Merge "Add --classes optional flag in list_files" am: 32efc846f5
Original change: https://android-review.googlesource.com/c/platform/build/+/2635796

Change-Id: I3f1b68df47329a20a3fc4deef295e25b0c1315f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 10:24:21 +00:00
Treehugger Robot
32efc846f5 Merge "Add --classes optional flag in list_files" 2023-06-30 09:36:42 +00:00
Wei Li
6eeaabaa81 Merge "Revert "Revert "Support SBOM generation of m build unbundled APEXs.""" am: f711149a5c am: a42c88228e
Original change: https://android-review.googlesource.com/c/platform/build/+/2645005

Change-Id: Ia404bb37c1212988625f4fcfa84ff26f018a4752
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 09:16:37 +00:00
Wei Li
a42c88228e Merge "Revert "Revert "Support SBOM generation of m build unbundled APEXs.""" am: f711149a5c
Original change: https://android-review.googlesource.com/c/platform/build/+/2645005

Change-Id: I1af56a79a3316f29014fbc7f78020972f1b22c48
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 08:37:53 +00:00
Wei Li
f711149a5c Merge "Revert "Revert "Support SBOM generation of m build unbundled APEXs.""" 2023-06-30 07:53:45 +00:00
Chuong Hoang
b684a13c1c Add brightness-related TARGET_RECOVERY_UI_ properties
Bug: 221048336
Test: combined with the other CL in same topic, observed recovery
brightness updated correctly according to variables set in BoardConfig.

Change-Id: Iebad0753079414a5e11bce04008ee405c8d03580
2023-06-30 04:44:23 +00:00
Wenshan Fu
13be0a5f98 Create the TEST_MAPPING file
Add FlagAnnotationTests in presubmit to ensure that test filtering rule
always works as expected.

Test: atest --test-mapping
Bug: 277819423
Change-Id: I7cc3a70495f8d62ed7a5b26edc4fd240e73ccf61
2023-06-30 03:28:02 +00:00
Wei Li
50745668c3 Revert "Revert "Support SBOM generation of m build unbundled APEXs.""
This reverts commit bab162156e.

Reason for revert: issue is fixed in ag/23851209.

Change-Id: I965d535771f0bd6eb0e6da66b2c2cc3fd7f194c9
2023-06-30 02:33:36 +00:00
David Duarte
d759b3517a Enable CFI for the whole Bluetooth repo and not just system
Bug: 282222542
Change-Id: Idd0e0c4ab01e703190038c103b41730d68f01be0
2023-06-29 21:01:48 +00:00
Jiakai Zhang
893bdf484b Merge "Use per-app package list to avoid unnecessary dexpreopt." am: f164097056 am: 88cc0b3f21
Original change: https://android-review.googlesource.com/c/platform/build/+/2638489

Change-Id: I909aeb83f0ff473cc95a7e6e0deeeb425fa41ede
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 19:06:12 +00:00
Jiakai Zhang
88cc0b3f21 Merge "Use per-app package list to avoid unnecessary dexpreopt." am: f164097056
Original change: https://android-review.googlesource.com/c/platform/build/+/2638489

Change-Id: Ia35c48adba03ad8c08844f5433ab6b0c8699f248
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 18:23:06 +00:00
Jiakai Zhang
f164097056 Merge "Use per-app package list to avoid unnecessary dexpreopt." 2023-06-29 17:33:43 +00:00
Treehugger Robot
e30c479502 Merge changes from topic "aconfig-package-ident-fixes" am: 9c3da21b6e am: 081d19bb1f
Original change: https://android-review.googlesource.com/c/platform/build/+/2643656

Change-Id: I3be7155d09ab344f5d8901227d85df3b0017f6a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 16:05:21 +00:00
Treehugger Robot
081d19bb1f Merge changes from topic "aconfig-package-ident-fixes" am: 9c3da21b6e
Original change: https://android-review.googlesource.com/c/platform/build/+/2643656

Change-Id: I7561912955cb11b7d1a9b903e637925f9f6f1ee9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 15:23:09 +00:00
Zhi Dou
8d27cc39b1 aconfig: Add resetAll method to test mode FeatureFlagsImpl
Add resetAll method to test mode FeatureFlagsImpl. This method
is used to reset all the flags values to null. It provides convenient
way to the test tools to reset the flags values.

Bug: 280833463
Test: atest aconfig.test
Change-Id: I4bf1d3ba69ee106ef8d0c1cc62c00bbeca1b72aa
2023-06-29 15:15:32 +00:00
Zhi Dou
a41cc5ecf9 aconfig: remove extra new lines and spaces in generated java code
Change the java template to remove the extra new lines and spaces
in generated java code.

Bug: 280833463
Test: atest aconfig.test
Change-Id: I336050540f8a2b0966bf21cf6e034a8fa701458e
2023-06-29 15:05:18 +00:00
Treehugger Robot
9c3da21b6e Merge changes from topic "aconfig-package-ident-fixes"
* changes:
  aconfig: package fields must contain at least one dot char
  aconfig: fix incorrect check in create_device_config_ident
  aconfig: improve package identifier test readability
2023-06-29 14:38:07 +00:00
Carlos Eduardo Seo
6e6a95b606 core: Add script to check for possible shared library duplication
Running dupcheck.sh after a build on an image performs two checks:

  * Check for duplicate shared libraries by MD5.
  * Check for possible duplicate shared libraries by comparing .note
    and .text ELF sections.

This helps looking for unnecessary file duplication in the final images.

Test: after running the script, reports will be generated in the 'out'
directory.

Change-Id: I91c044a52002557fdc8dc65bfc9fd5f313ca00f3
2023-06-29 12:50:10 +00:00
Mårten Kongstad
19776d19e6 aconfig: package fields must contain at least one dot char
Introduce a new requirement on package fields: a package must contain at
least one dot character.

Bug: 289336036
Test: atest aconfig.test
Change-Id: Idadcd2a76783a484cc5c6d6e94778c0248fa475f
2023-06-29 10:38:02 +02:00
Mårten Kongstad
c0d618c3a4 aconfig: fix incorrect check in create_device_config_ident
Use is_valid_name_ident to check the flag name, not
is_valid_package_ident.

Bug: 283910447
Test: atest aconfig.test
Change-Id: I3718e7de565b975a1696190e8effbcb077e5fde2
2023-06-29 10:18:20 +02:00
Mårten Kongstad
60ee8a633f aconfig: improve package identifier test readability
Rearrange the tests in test_is_valid_package_ident to make it more
apparent what constitutes a valid package pattern, and what doesn't.

Bug: 283910447
Test: atest aconfig.test
Change-Id: I3d2b87aed008d0ed3a0aa6e483e655178dda7277
2023-06-29 10:03:38 +02:00
Jooyung Han
d4190289cd Merge "Add apexd_host to otatools" am: 0f8339dcac am: 88afdc0beb
Original change: https://android-review.googlesource.com/c/platform/build/+/2643394

Change-Id: I7e5cd8a12208ac7423091db2fd2b06d52ad170f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 07:13:20 +00:00
Treehugger Robot
ae9d03e612 Merge "add sha256 to art-host-tests zip to lower rbe upload overhead" am: 6d2b198f87 am: dad161c5e8
Original change: https://android-review.googlesource.com/c/platform/build/+/2640232

Change-Id: Ia3879c973dd55ae22b75d927953080d6605ca314
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 07:13:09 +00:00
Jooyung Han
88afdc0beb Merge "Add apexd_host to otatools" am: 0f8339dcac
Original change: https://android-review.googlesource.com/c/platform/build/+/2643394

Change-Id: I849a2c571b2e58c37da0ca18343cdb76a75a55a9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 06:34:10 +00:00
Treehugger Robot
dad161c5e8 Merge "add sha256 to art-host-tests zip to lower rbe upload overhead" am: 6d2b198f87
Original change: https://android-review.googlesource.com/c/platform/build/+/2640232

Change-Id: I591dcac500a1083ba034c56670e673aff7c5ea8f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 06:33:57 +00:00
Jooyung Han
0f8339dcac Merge "Add apexd_host to otatools" 2023-06-29 06:01:38 +00:00