Commit Graph

8 Commits

Author SHA1 Message Date
Nikita Putikhin
8722201866 Use test install base template instead of a hardcoded path
** This CL reapplies aosp/3150696. Now it is connected to a
corresponding change in rust soong module to ensure system test dir does
not change to avoid b/350479879. **

Make the template more consistent with the native (aka cc) test temlate.

The important change is that vendor tests will be pushed into
/data/local/tests/vendor.

Having the test binary in the vendor test folder makes the linker treat
it as a vendor binary and prefer vendor libraries. Previously, the test
binary was always a system binary (due to being in /data/local/tmp) and
used system libraries first potentially leading to bugs (e.g. the one
attached).

This change also makes vendor tests that use vendor libraries require
root due to an existing SELinux policy issue with atest.

Bug: 347370677
Test: checked with:
 - libsecretkeeper_core_test
 - libauthgraph_boringssl_test
 - libdice_policy.test
 Test steps:
 atest -d <test>.vendor # runs vendor variant, passes
 adb root
 adb shell find / -iname <test> 2>/dev/null
 # before change: /data/local/tmp/<test>
 # after change: /data/local/tests/vendor/<test>
Test: v2/android-kvm-team/avf_presubmit_tests
Change-Id: I19793bd20bc23ff0c78e622bc6b93f9a90d725c0
2024-07-16 12:41:19 +00:00
Nikita Putikhin
fc4ac4873d Revert "Use test install base template instead of a hardcoded path"
This reverts commit f6a22b6ff7.

Reason for revert: b/350479879

Change-Id: I282719de6579670d382dd5429efe62ab7832cc95
2024-07-01 15:31:21 +00:00
Nikita Putikhin
f6a22b6ff7 Use test install base template instead of a hardcoded path
Make the template more consistent with the native (aka cc) test temlate.

The important change is that vendor tests will be pushed into
/data/local/tests/vendor. In fact, rust module in soong already expects
this (aosp/1832614).

Having the test binary in the vendor test folder makes the linker treat
it as a vendor binary and prefer vendor libraries. Previously, the test
binary was always a system binary (due to being in /data/local/tmp) and
used system libraries first potentially leading to bugs (e.g. the one
attached).

This change also makes vendor tests that use vendor libraries require
root due to an existing SELinux policy issue with atest.

Bug: 347370677
Test: checked with:
 - libsecretkeeper_core_test
 - libauthgraph_boringssl_test (with the chained change)
 - libdice_policy.test
 Test steps:
 atest -d <test>.vendor # runs vendor variant, passes
 adb root
 adb shell find / -iname <test> 2>/dev/null
 # before change: /data/local/tmp/<test>
 # after change: /data/local/tests/vendor/<test>
Change-Id: I6d8c58cbce5b636480803e74cb710f0b05b74e10
2024-06-27 16:43:38 +02:00
Ivan Lozano
bdf229ce99 Merge "rust: Add EXTRA_CONFIGS to rust test template" 2021-09-24 18:39:47 +00:00
Guang Zhu
97278c1828 Revert "update build rules to use /data/local/tests/unrestricted"
Revert "update build rules to use /data/local/tests/unrestricted"

Revert submission 1826231-native-test-path

Bug: 199996863

Reason for revert: b/199996863
Reverted Changes:
Ic106011a7:update build rules to use /data/local/tests/unrest...
Id727355ec:update build rules to use /data/local/tests/unrest...

Change-Id: I18301ab3effacd43ff2f136bba9d3244b497a54b
2021-09-22 04:20:05 +00:00
Ivan Lozano
b74088f8b0 rust: Add EXTRA_CONFIGS to rust test template
Bug: 200602232
Test: Extra configs are in generated config
Change-Id: I4abd822f970747a176a746c00d0fa5246441f331
2021-09-21 12:31:22 -04:00
Guang Zhu
a736c45a95 update build rules to use /data/local/tests/unrestricted
... for native tests. This new location has the appropriate
settings for debuggerd to generate valid backtraces in case
of test binary crash.

Bug: 167308193
Bug: 199904562
Test: compile
Change-Id: Id727355ecc87415ba1e7ccc41ec55d2f6f5fc6f1
2021-09-14 10:58:14 -07:00
Chih-Hung Hsieh
0d51f2fe2f Add rust_device_test_config_template.xml
* Derived from native_test_config_template.xml

Bug: 140938178
Test: make rust projects
Change-Id: I5bfeb0a578cb0fcf134eb9b524a6d3e5b6eeafcc
2019-12-02 17:44:47 +00:00