Commit Graph

87306 Commits

Author SHA1 Message Date
Mårten Kongstad
83a8760bbc aconfig: add test utilities
Create a test utility function to create a Cache from the files in
testdata/*. A follow-up CL will update the unit tests to use this
instead of creating their own caches.

Bug: 283910447
Test: atest aconfig.test
Change-Id: Ice5064eadb0babde5eb38d292330d213ab136d96
2023-06-02 12:54:22 +02:00
Mårten Kongstad
1cd166cd31 aconfig: cache.rs: remove unnecessary use statements
Remove unnecessary use from the cache::test module: they already covered
by `use super:*;`.

Bug: 283910447
Test: atest aconfig.test
Change-Id: I9e03385629f38180c0f92080c7f097a8e0d9ef69
2023-06-02 12:52:48 +02:00
Mårten Kongstad
b27f2ce436 aconfig: give commands ownership of all arguments
Pass the Cache argument to command::create_<lang>_lib functions by value
instead of by reference, to align with other commands.

The intended ownership flow is as follows:

  - main creates objects based on command line arguments
  - main hands commands ownership of the objects
  - command processes the objects
  - command gives main ownership of any generated output
  - main writes the output to file

Rationale: commands.rs is a unit testable version of main, and to the
rest of aconfig, acts as the top level entry point; main.rs exists only
to parse command line arguments and perform I/O.

Bug: 283910447
Test: atest aconfig.test
Change-Id: I1e1dea7da8ecc2bb6e2f7ee4a6df64562c148959
2023-06-02 12:49:26 +02:00
Florian Mayer
4029e4f31c Merge "Use linker_hwasan64 for make built HWASan executables" am: 5e2c1bec02 am: 6dfa7b4dec am: 138a31d1da
Original change: https://android-review.googlesource.com/c/platform/build/+/2612134

Change-Id: I281eac023f59abcc87ddb759108cbec2930690fe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 06:37:15 +00:00
Florian Mayer
138a31d1da Merge "Use linker_hwasan64 for make built HWASan executables" am: 5e2c1bec02 am: 6dfa7b4dec
Original change: https://android-review.googlesource.com/c/platform/build/+/2612134

Change-Id: Ia44a9a1a4e81c953a2a16081b1a59773a8e11c80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 05:51:40 +00:00
Jooyung Han
4b8c962c7b Deprecation message for TARGET_FLATTEN_APEX
Bug: 278826656
Test: OVERRIDE_TARGET_FLATTEN_APEX=true m nothing (shows warning)
Change-Id: I60e463348f87d8e1520245702eaa99c4c5356b61
2023-06-02 14:15:34 +09:00
Florian Mayer
6dfa7b4dec Merge "Use linker_hwasan64 for make built HWASan executables" am: 5e2c1bec02
Original change: https://android-review.googlesource.com/c/platform/build/+/2612134

Change-Id: I09412a2be8e44277757889f1fc99a5866c6294af
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 05:10:28 +00:00
Kelvin Zhang
1381491303 Merge "Adding vendor_kernel_boot to fasboot-info" am: bf8e3d5dc8 am: f634cf3947 am: 33b352ad24
Original change: https://android-review.googlesource.com/c/platform/build/+/2609160

Change-Id: I5d6632bb2e1f9f0fceaa49ea982c845a0380edcd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 05:09:21 +00:00
Florian Mayer
5e2c1bec02 Merge "Use linker_hwasan64 for make built HWASan executables" 2023-06-02 04:30:18 +00:00
Kelvin Zhang
33b352ad24 Merge "Adding vendor_kernel_boot to fasboot-info" am: bf8e3d5dc8 am: f634cf3947
Original change: https://android-review.googlesource.com/c/platform/build/+/2609160

Change-Id: Ic9333e183a7538ff6ac69a56e58166aa3268c338
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 04:25:28 +00:00
Kelvin Zhang
f634cf3947 Merge "Adding vendor_kernel_boot to fasboot-info" am: bf8e3d5dc8
Original change: https://android-review.googlesource.com/c/platform/build/+/2609160

Change-Id: Iece6f4069c0b75666e1125d2523f23fd291e4efe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 03:42:46 +00:00
Kelvin Zhang
bf8e3d5dc8 Merge "Adding vendor_kernel_boot to fasboot-info" 2023-06-02 02:57:37 +00:00
Treehugger Robot
3c41d4bdb5 [automerger skipped] Merge "Support dynamic 64-bit drmserver" into udc-dev am: cd3752d163 -s ours
am skip reason: Merged-In I874cee00a066086f565e044549ad40c6ab5d62b0 with SHA-1 fb27c2954f is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/23304977

Change-Id: I8e17b0010a6640d87e4146c2c174979017cd0a16
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 00:13:48 +00:00
SzuWei Lin
42d2870495 [automerger skipped] Support dynamic 64-bit drmserver am: 0dce348046 -s ours
am skip reason: Merged-In I874cee00a066086f565e044549ad40c6ab5d62b0 with SHA-1 fb27c2954f is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/build/+/23304977

Change-Id: Iea7bb6a7b16392078a989db98b476c0a97abc1d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 00:13:44 +00:00
Treehugger Robot
eb6c9b7921 Merge "Open ab_partitions.txt with just read access" am: f9a6f5f06b am: b5535214ad am: 4cd34e5ce6
Original change: https://android-review.googlesource.com/c/platform/build/+/2611511

Change-Id: I263ecf630f7e62caaa6a70e4642f02122dfb64d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 00:13:28 +00:00
Treehugger Robot
4cd34e5ce6 Merge "Open ab_partitions.txt with just read access" am: f9a6f5f06b am: b5535214ad
Original change: https://android-review.googlesource.com/c/platform/build/+/2611511

Change-Id: I5f78de5ef067ee26644a82381fc85c5f81b73e03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 23:28:18 +00:00
Treehugger Robot
cd3752d163 Merge "Support dynamic 64-bit drmserver" into udc-dev 2023-06-01 23:22:32 +00:00
Treehugger Robot
b5535214ad Merge "Open ab_partitions.txt with just read access" am: f9a6f5f06b
Original change: https://android-review.googlesource.com/c/platform/build/+/2611511

Change-Id: I075bf60c1586dd0af5d39cc23db97e9ae5c5532d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 22:42:53 +00:00
Treehugger Robot
f9a6f5f06b Merge "Open ab_partitions.txt with just read access" 2023-06-01 21:39:35 +00:00
Daniel Zheng
ee10d07057 Adding option to disable fastboot_info
Fastboot_info can be disabled if use_fastboot_info is set to false.
Adding this flag as fastboot-info.txt is currently broken

Test: m updatepackage -> inspect contents
Bug: 284263071
Change-Id: I3e0ca13968ba9747cc39284ea6798981d22ad5e5
2023-06-01 14:21:58 -07:00
Florian Mayer
97222e192a Use linker_hwasan64 for make built HWASan executables
Test: build chre on oriole_hwasan
      verify linker with `file`
Bug: 276930343
Change-Id: I92e07b38f9198fc72f4aa3418420cc155085b324
2023-06-01 14:21:54 -07:00
Kelvin Zhang
89b87f6aa9 Open ab_partitions.txt with just read access
We don't actually need write permission, so going with least privilege
principle. We have observed some mysterious permission denied errors on server environments. Without detailed logs or access to the server it's hard to pinpoint what the root cause is. This is an attempt/hypothesis to fix the permission denied error.

Test: th
Bug: 283033491
Change-Id: I52dc360d593aab57c749109994bf3e1e3625d0ce
2023-06-01 17:28:25 +00:00
Rob Seymour
0aaa561255 Do not set DISABLE_PREOPT_BOOT_IMAGES when doing a VSDK build.
Bug: 283843071
Test: build vsdk based image
Change-Id: Id35196d266994fe222f55a0711b52938253d48a7
2023-06-01 16:48:46 +00:00
Jiakai Zhang
f09e76c173 Drop INTERNAL_PLATFORM_MISSING_USES_LIBRARIES.
INTERNAL_PLATFORM_MISSING_USES_LIBRARIES was a workaround for CLC
construction. It's no longer needed because we have deferred the CLC
construction to Ninja phase.

Bug: 282877248
Test: Presubmit build tests.
Change-Id: Ib5d59caf58394f3bb93b4338146cbbbd58bb4f34
2023-06-01 16:44:35 +01:00
Treehugger Robot
86c394f1c1 Merge "Do not include SoundPicker on Android TV" am: 05e0a133aa am: 2939790301 am: 14396e5797
Original change: https://android-review.googlesource.com/c/platform/build/+/2604845

Change-Id: Ie69e19ee9d958f73303753aba85ed135a6255a6c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 01:41:14 +00:00
Treehugger Robot
14396e5797 Merge "Do not include SoundPicker on Android TV" am: 05e0a133aa am: 2939790301
Original change: https://android-review.googlesource.com/c/platform/build/+/2604845

Change-Id: I829c4b938fec05f9c331b80dce93df330437aecc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 00:52:32 +00:00
Treehugger Robot
2939790301 Merge "Do not include SoundPicker on Android TV" am: 05e0a133aa
Original change: https://android-review.googlesource.com/c/platform/build/+/2604845

Change-Id: If5f51e4e7f5e0eea972d8c87790afdd209c1f6de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 00:05:17 +00:00
Treehugger Robot
05e0a133aa Merge "Do not include SoundPicker on Android TV" 2023-05-31 23:21:43 +00:00
Steven Moreland
41792255af Remove PRODUCT_SEPOLICY_SPLIT.
Obsolete.

Bug: 257176017
Test: build&boot
Change-Id: I7ac95f8e55254b7c07ee5e5ba6c18c23a432bfa1
2023-05-31 22:01:16 +00:00
Treehugger Robot
b39f4821b9 Merge "Enable UFFD GC." am: 4f6a18d4cf am: c7f4692afa am: f7fc3bf28d
Original change: https://android-review.googlesource.com/c/platform/build/+/2607296

Change-Id: Ib379008d9e6ec231c8bfbad65ddfecd6a117b923
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 17:48:57 +00:00
Treehugger Robot
f7fc3bf28d Merge "Enable UFFD GC." am: 4f6a18d4cf am: c7f4692afa
Original change: https://android-review.googlesource.com/c/platform/build/+/2607296

Change-Id: Ie838eba53916c0f28807cdfad148c4386ce7199b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 15:18:00 +00:00
Treehugger Robot
c7f4692afa Merge "Enable UFFD GC." am: 4f6a18d4cf
Original change: https://android-review.googlesource.com/c/platform/build/+/2607296

Change-Id: Id6580ac9655505ed945d0903ed9ecfa34b6a7c40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-31 14:36:36 +00:00
Dennis Shen
6461673140 aconfig: update rust code gen to use libflags_rust
Bug: b/284096062, b/279483360
Test: atest aconfig.test
Change-Id: I4c96f35807de5cb2a745ba1c653513d9b22a5013
2023-05-31 14:35:59 +00:00
Treehugger Robot
4f6a18d4cf Merge "Enable UFFD GC." 2023-05-31 13:33:13 +00:00
Treehugger Robot
1fe7af4274 Merge "aconfig: restrict valid namespace and flag names" am: cfc5f5e9fd am: 2d8615198c am: 6129693adb
Original change: https://android-review.googlesource.com/c/platform/build/+/2607087

Change-Id: Ic26969bbb8b273ceeabd4004e2b3ac07815fac03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 22:11:32 +00:00
Treehugger Robot
6129693adb Merge "aconfig: restrict valid namespace and flag names" am: cfc5f5e9fd am: 2d8615198c
Original change: https://android-review.googlesource.com/c/platform/build/+/2607087

Change-Id: I5fc252638c5b49648d678279cd5d9b9a91299558
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 21:26:31 +00:00
Daniel Zheng
7d85d4f7b7 Adding vendor_kernel_boot to fasboot-info
Adding new partition to fastboot-info

Test: m fastboot_info
Bug: 284263071
Change-Id: I2540cbc224ebaffe5781c7aa3570e3e56f1bdcdd
2023-05-30 14:22:19 -07:00
Treehugger Robot
2d8615198c Merge "aconfig: restrict valid namespace and flag names" am: cfc5f5e9fd
Original change: https://android-review.googlesource.com/c/platform/build/+/2607087

Change-Id: Ifb0c77ff4e3c51f8bd0dce787abb022946518c79
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 20:42:52 +00:00
Treehugger Robot
cfc5f5e9fd Merge "aconfig: restrict valid namespace and flag names" 2023-05-30 19:35:48 +00:00
Jiakai Zhang
84519942cb Merge "Move CLC construction to Ninja phase." am: d5d51e21bf am: 8c2c816a8a am: ba795042a6
Original change: https://android-review.googlesource.com/c/platform/build/+/2595208

Change-Id: I57900d8af04538fb67c8e4c135314d3dd4afdd80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 17:08:09 +00:00
Jiakai Zhang
ba795042a6 Merge "Move CLC construction to Ninja phase." am: d5d51e21bf am: 8c2c816a8a
Original change: https://android-review.googlesource.com/c/platform/build/+/2595208

Change-Id: I5b36a475c0e6b2f37988359a4eb1455224587f8b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 16:21:15 +00:00
Jiakai Zhang
8c2c816a8a Merge "Move CLC construction to Ninja phase." am: d5d51e21bf
Original change: https://android-review.googlesource.com/c/platform/build/+/2595208

Change-Id: I5db0541400045de4a6f4e56a5771fa69498021b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 15:42:08 +00:00
Jiakai Zhang
117212e422 Enable UFFD GC.
Bug: 160737021
Change-Id: Ic19c8764087607338963b0e5d351ff14f536dd20
Test: Presbumit
2023-05-30 15:22:40 +00:00
Jiakai Zhang
d5d51e21bf Merge "Move CLC construction to Ninja phase." 2023-05-30 14:58:15 +00:00
Kiyoung Kim
d1ccbf1134 Merge "Rename soong.variable with target product" am: 6a821158b1 am: 96febf79e6 am: bdc8e89daa
Original change: https://android-review.googlesource.com/c/platform/build/+/2556453

Change-Id: I284b3dca8b6e47db5c7e3d893e761268530e5427
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 09:21:27 +00:00
Kiyoung Kim
bdc8e89daa Merge "Rename soong.variable with target product" am: 6a821158b1 am: 96febf79e6
Original change: https://android-review.googlesource.com/c/platform/build/+/2556453

Change-Id: I9b0383bd44912aafc52b917ed25c0f9ca229fc43
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 08:33:18 +00:00
Kiyoung Kim
96febf79e6 Merge "Rename soong.variable with target product" am: 6a821158b1
Original change: https://android-review.googlesource.com/c/platform/build/+/2556453

Change-Id: I2ebab3ef3582650064ea40d70275ce5393f63674
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-30 07:48:35 +00:00
Kiyoung Kim
6a821158b1 Merge "Rename soong.variable with target product" 2023-05-30 07:17:08 +00:00
Seigo Nonaka
1260450745 Include RobotoFlex into AOSP system image
Bug: 235303866
Test: Manually done
Change-Id: I8ff5ef9441b8103d87bd4eb575e5abe87a2750c1
2023-05-29 17:49:20 +09:00
Dan Shi
1e4d747628 Support test runnner option in auto generated test configs
Bug: 284179405
Bug: 236980335
Test: unittest
Change-Id: I7f96a2a2bc52316888e87af7e4bcc4ef50863716
2023-05-26 21:35:10 +00:00