Remove the hand-crafted wrappers around the structures auto-generated from protos/aconfig.proto, and use the auto-generated structs directly intead. This gets rid of a lot of manual repetition, and its inherent risk. Also unify how individual fields read from text proto are verified (e.g. is the flag.name field a valid identifier). Also change the intermediate cache format from JSON to binary protobuf. The concept of a 'cache' as an intermediate internal format to represent parsed input stays. The command line interface still refers to caches. At the moment a cache file is identical to a parsed_file protbuf, and the code exploits this internally. A couple of points regarding the auto-generated structs: - Vectors are named in the singular (e.g. parsed_flags.parsed_flag is a Vec<ProtoParsedFlag>) because this improves ergonomics for all devs working with aconfig input files - The auto-generated structs have fields that are of type Option<T> and convenience methods (named the same as the fields) to access T Test: atest aconfig.test aconfig.test.java Bug: 283910447 Change-Id: I512820cc4bc6c543dea9f6a4356f863120a10be3
140 lines
4.6 KiB
Rust
140 lines
4.6 KiB
Rust
/*
|
|
* Copyright (C) 2023 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
use anyhow::Result;
|
|
use serde::Serialize;
|
|
use tinytemplate::TinyTemplate;
|
|
|
|
use crate::codegen;
|
|
use crate::commands::OutputFile;
|
|
use crate::protos::{ProtoFlagPermission, ProtoFlagState, ProtoParsedFlag};
|
|
|
|
pub fn generate_rust_code<'a, I>(package: &str, parsed_flags_iter: I) -> Result<OutputFile>
|
|
where
|
|
I: Iterator<Item = &'a ProtoParsedFlag>,
|
|
{
|
|
let template_flags: Vec<TemplateParsedFlag> =
|
|
parsed_flags_iter.map(|pf| TemplateParsedFlag::new(package, pf)).collect();
|
|
let context = TemplateContext {
|
|
package: package.to_string(),
|
|
template_flags,
|
|
modules: package.split('.').map(|s| s.to_string()).collect::<Vec<_>>(),
|
|
};
|
|
let mut template = TinyTemplate::new();
|
|
template.add_template("rust_code_gen", include_str!("../templates/rust.template"))?;
|
|
let contents = template.render("rust_code_gen", &context)?;
|
|
let path = ["src", "lib.rs"].iter().collect();
|
|
Ok(OutputFile { contents: contents.into(), path })
|
|
}
|
|
|
|
#[derive(Serialize)]
|
|
struct TemplateContext {
|
|
pub package: String,
|
|
pub template_flags: Vec<TemplateParsedFlag>,
|
|
pub modules: Vec<String>,
|
|
}
|
|
|
|
#[derive(Serialize)]
|
|
struct TemplateParsedFlag {
|
|
pub name: String,
|
|
pub device_config_namespace: String,
|
|
pub device_config_flag: String,
|
|
|
|
// TinyTemplate's conditionals are limited to single <bool> expressions; list all options here
|
|
// Invariant: exactly one of these fields will be true
|
|
pub is_read_only_enabled: bool,
|
|
pub is_read_only_disabled: bool,
|
|
pub is_read_write: bool,
|
|
}
|
|
|
|
impl TemplateParsedFlag {
|
|
#[allow(clippy::nonminimal_bool)]
|
|
fn new(package: &str, pf: &ProtoParsedFlag) -> Self {
|
|
let template = TemplateParsedFlag {
|
|
name: pf.name().to_string(),
|
|
device_config_namespace: pf.namespace().to_string(),
|
|
device_config_flag: codegen::create_device_config_ident(package, pf.name())
|
|
.expect("values checked at flag parse time"),
|
|
is_read_only_enabled: pf.permission() == ProtoFlagPermission::READ_ONLY
|
|
&& pf.state() == ProtoFlagState::ENABLED,
|
|
is_read_only_disabled: pf.permission() == ProtoFlagPermission::READ_ONLY
|
|
&& pf.state() == ProtoFlagState::DISABLED,
|
|
is_read_write: pf.permission() == ProtoFlagPermission::READ_WRITE,
|
|
};
|
|
#[rustfmt::skip]
|
|
debug_assert!(
|
|
(template.is_read_only_enabled && !template.is_read_only_disabled && !template.is_read_write) ||
|
|
(!template.is_read_only_enabled && template.is_read_only_disabled && !template.is_read_write) ||
|
|
(!template.is_read_only_enabled && !template.is_read_only_disabled && template.is_read_write),
|
|
"TemplateParsedFlag invariant failed: {} {} {}",
|
|
template.is_read_only_enabled,
|
|
template.is_read_only_disabled,
|
|
template.is_read_write,
|
|
);
|
|
template
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_generate_rust_code() {
|
|
let parsed_flags = crate::test::parse_test_flags();
|
|
let generated =
|
|
generate_rust_code(crate::test::TEST_PACKAGE, parsed_flags.parsed_flag.iter()).unwrap();
|
|
assert_eq!("src/lib.rs", format!("{}", generated.path.display()));
|
|
let expected = r#"
|
|
pub mod com {
|
|
pub mod android {
|
|
pub mod aconfig {
|
|
pub mod test {
|
|
#[inline(always)]
|
|
pub const fn r#disabled_ro() -> bool {
|
|
false
|
|
}
|
|
|
|
#[inline(always)]
|
|
pub fn r#disabled_rw() -> bool {
|
|
flags_rust::GetServerConfigurableFlag("aconfig_test", "com.android.aconfig.test.disabled_rw", "false") == "true"
|
|
}
|
|
|
|
#[inline(always)]
|
|
pub const fn r#enabled_ro() -> bool {
|
|
true
|
|
}
|
|
|
|
#[inline(always)]
|
|
pub fn r#enabled_rw() -> bool {
|
|
flags_rust::GetServerConfigurableFlag("aconfig_test", "com.android.aconfig.test.enabled_rw", "false") == "true"
|
|
}
|
|
|
|
}
|
|
}
|
|
}
|
|
}
|
|
"#;
|
|
assert_eq!(
|
|
None,
|
|
crate::test::first_significant_code_diff(
|
|
expected,
|
|
&String::from_utf8(generated.contents).unwrap()
|
|
)
|
|
);
|
|
}
|
|
}
|