b0f3a4d04c
The platform availability check was erroring incorrectly for the libstatssocket module in master-art-host builds. Nothing being built depended on libstatssocket, but the check would still error because libstatspull_test was defined in the branch but unused in the build. When ALLOW_MISSING_DEPENDENCIES=true is set and a module fails the check add an additional dependency on a rule that prints the error message. This will show the error and fail the build if an unavailable module is requested to be installed, while allowing the build to proceed if there are no unavailable modules in the dependency graph. Fixes: 154888298 Test: m build-art-host TARGET_BUILD_UNBUNDLED=true ALLOW_MISSING_DEPENDENCIES=true libstatspull_test -k Test: m build-art-host TARGET_BUILD_UNBUNDLED=true ALLOW_MISSING_DEPENDENCIES=true Change-Id: I1d57afe60a75d65128e59f794243a0414cbc82f6
57 lines
2.2 KiB
Makefile
57 lines
2.2 KiB
Makefile
#
|
|
# Copyright (C) 2020 The Android Open Source Project
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
|
|
# Check whether there is any module that isn't available for platform
|
|
# is installed to the platform.
|
|
|
|
# Filter FAKE and NON_INSTALLABLE modules out and then collect those are not
|
|
# available for platform
|
|
_modules_not_available_for_platform := \
|
|
$(strip $(foreach m,$(product_MODULES),\
|
|
$(if $(filter-out FAKE,$(ALL_MODULES.$(m).CLASS)),\
|
|
$(if $(ALL_MODULES.$(m).INSTALLED),\
|
|
$(if $(filter true,$(ALL_MODULES.$(m).NOT_AVAILABLE_FOR_PLATFORM)),\
|
|
$(m))))))
|
|
|
|
ifndef ALLOW_MISSING_DEPENDENCIES
|
|
_violators_with_path := $(foreach m,$(sort $(_modules_not_available_for_platform)),\
|
|
$(m):$(word 1,$(ALL_MODULES.$(m).PATH))\
|
|
)
|
|
|
|
$(call maybe-print-list-and-error,$(_violators_with_path),\
|
|
Following modules are requested to be installed. But are not available \
|
|
for platform because they do not have "//apex_available:platform" or \
|
|
they depend on other modules that are not available for platform)
|
|
|
|
else
|
|
|
|
# Don't error out immediately when ALLOW_MISSING_DEPENDENCIES is set.
|
|
# Instead, add a dependency on a rule that prints the error message.
|
|
define not_available_for_platform_rule
|
|
not_installable_file := $(patsubst $(OUT_DIR)/%,$(OUT_DIR)/NOT_AVAILABLE_FOR_PLATFORM/%,$(1)))
|
|
$(1): $$(not_installable_file)
|
|
$$(not_installable_file):
|
|
$(call echo-error,$(2),Module is requested to be installed but is not \
|
|
available for platform because it does not have "//apex_available:platform" or \
|
|
it depends on other modules that are not available for platform.)
|
|
exit 1
|
|
endef
|
|
|
|
$(foreach m,$(_modules_not_available_for_platform),\
|
|
$(foreach i,$(ALL_MODULES.$(m).INSTALLED),\
|
|
$(eval $(call not_available_for_platform_rule,$(i),$(m)))))
|
|
endif
|