The image building functions in build_image.py have been returning (success, result) or special values to indicate the validity of the result. The same logic can be better expressed by raising exceptions instead, because a) using a special value relies on caller to check for that magic value; b) exceptions can carry additional messages other than a boolean does, e.g. the output from the failing command; c) caller can have cleaner code flow without explicitly checking for the validity of the result. This CL changes such functions to raise on errors. The majority of these functions are internal to build_image.py only, except for BuildImage() that has a few callers in add_img_to_target_files.py (which all die upon error anyway). Test: `m dist` Test: python -m unittest test_build_image Test: python -m unittest test_add_img_to_target_files Test: python -m unittest test_validate_target_files Test: Inject an error to the depended binaries (e.g. avbtool), and check that build_image.py exits with error messages. Change-Id: Ibe4d51e267756bb1a00fa9238a213f9d55fd9b58
166 lines
5.5 KiB
Python
166 lines
5.5 KiB
Python
#
|
|
# Copyright (C) 2018 The Android Open Source Project
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
|
|
"""Unittests for validate_target_files.py."""
|
|
|
|
from __future__ import print_function
|
|
|
|
import os
|
|
import os.path
|
|
import shutil
|
|
import subprocess
|
|
import unittest
|
|
|
|
import build_image
|
|
import common
|
|
import test_utils
|
|
from validate_target_files import ValidateVerifiedBootImages
|
|
|
|
|
|
class ValidateTargetFilesTest(unittest.TestCase):
|
|
|
|
def setUp(self):
|
|
self.testdata_dir = test_utils.get_testdata_dir()
|
|
|
|
def tearDown(self):
|
|
common.Cleanup()
|
|
|
|
def _generate_boot_image(self, output_file):
|
|
kernel = common.MakeTempFile(prefix='kernel-')
|
|
with open(kernel, 'wb') as kernel_fp:
|
|
kernel_fp.write(os.urandom(10))
|
|
|
|
cmd = ['mkbootimg', '--kernel', kernel, '-o', output_file]
|
|
proc = common.Run(cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
|
|
stdoutdata, _ = proc.communicate()
|
|
self.assertEqual(
|
|
0, proc.returncode,
|
|
"Failed to run mkbootimg: {}".format(stdoutdata))
|
|
|
|
cmd = ['boot_signer', '/boot', output_file,
|
|
os.path.join(self.testdata_dir, 'testkey.pk8'),
|
|
os.path.join(self.testdata_dir, 'testkey.x509.pem'), output_file]
|
|
proc = common.Run(cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
|
|
stdoutdata, _ = proc.communicate()
|
|
self.assertEqual(
|
|
0, proc.returncode,
|
|
"Failed to sign boot image with boot_signer: {}".format(stdoutdata))
|
|
|
|
def test_ValidateVerifiedBootImages_bootImage(self):
|
|
input_tmp = common.MakeTempDir()
|
|
os.mkdir(os.path.join(input_tmp, 'IMAGES'))
|
|
boot_image = os.path.join(input_tmp, 'IMAGES', 'boot.img')
|
|
self._generate_boot_image(boot_image)
|
|
|
|
info_dict = {
|
|
'boot_signer' : 'true',
|
|
}
|
|
options = {
|
|
'verity_key' : os.path.join(self.testdata_dir, 'testkey.x509.pem'),
|
|
}
|
|
ValidateVerifiedBootImages(input_tmp, info_dict, options)
|
|
|
|
def test_ValidateVerifiedBootImages_bootImage_wrongKey(self):
|
|
input_tmp = common.MakeTempDir()
|
|
os.mkdir(os.path.join(input_tmp, 'IMAGES'))
|
|
boot_image = os.path.join(input_tmp, 'IMAGES', 'boot.img')
|
|
self._generate_boot_image(boot_image)
|
|
|
|
info_dict = {
|
|
'boot_signer' : 'true',
|
|
}
|
|
options = {
|
|
'verity_key' : os.path.join(self.testdata_dir, 'verity.x509.pem'),
|
|
}
|
|
self.assertRaises(
|
|
AssertionError, ValidateVerifiedBootImages, input_tmp, info_dict,
|
|
options)
|
|
|
|
def test_ValidateVerifiedBootImages_bootImage_corrupted(self):
|
|
input_tmp = common.MakeTempDir()
|
|
os.mkdir(os.path.join(input_tmp, 'IMAGES'))
|
|
boot_image = os.path.join(input_tmp, 'IMAGES', 'boot.img')
|
|
self._generate_boot_image(boot_image)
|
|
|
|
# Corrupt the late byte of the image.
|
|
with open(boot_image, 'r+b') as boot_fp:
|
|
boot_fp.seek(-1, os.SEEK_END)
|
|
last_byte = boot_fp.read(1)
|
|
last_byte = chr(255 - ord(last_byte))
|
|
boot_fp.seek(-1, os.SEEK_END)
|
|
boot_fp.write(last_byte)
|
|
|
|
info_dict = {
|
|
'boot_signer' : 'true',
|
|
}
|
|
options = {
|
|
'verity_key' : os.path.join(self.testdata_dir, 'testkey.x509.pem'),
|
|
}
|
|
self.assertRaises(
|
|
AssertionError, ValidateVerifiedBootImages, input_tmp, info_dict,
|
|
options)
|
|
|
|
def _generate_system_image(self, output_file):
|
|
verity_fec = True
|
|
partition_size = 1024 * 1024
|
|
image_size, verity_size = build_image.AdjustPartitionSizeForVerity(
|
|
partition_size, verity_fec)
|
|
|
|
# Use an empty root directory.
|
|
system_root = common.MakeTempDir()
|
|
cmd = ['mkuserimg_mke2fs', '-s', system_root, output_file, 'ext4',
|
|
'/system', str(image_size), '-j', '0']
|
|
proc = common.Run(cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
|
|
stdoutdata, _ = proc.communicate()
|
|
self.assertEqual(
|
|
0, proc.returncode,
|
|
"Failed to create system image with mkuserimg_mke2fs: {}".format(
|
|
stdoutdata))
|
|
|
|
# Append the verity metadata.
|
|
prop_dict = {
|
|
'partition_size' : str(partition_size),
|
|
'image_size' : str(image_size),
|
|
'verity_block_device' : '/dev/block/system',
|
|
'verity_key' : os.path.join(self.testdata_dir, 'testkey'),
|
|
'verity_signer_cmd' : 'verity_signer',
|
|
'verity_size' : str(verity_size),
|
|
}
|
|
build_image.MakeVerityEnabledImage(output_file, verity_fec, prop_dict)
|
|
|
|
def test_ValidateVerifiedBootImages_systemImage(self):
|
|
input_tmp = common.MakeTempDir()
|
|
os.mkdir(os.path.join(input_tmp, 'IMAGES'))
|
|
system_image = os.path.join(input_tmp, 'IMAGES', 'system.img')
|
|
self._generate_system_image(system_image)
|
|
|
|
# Pack the verity key.
|
|
verity_key_mincrypt = os.path.join(
|
|
input_tmp, 'BOOT', 'RAMDISK', 'verity_key')
|
|
os.makedirs(os.path.dirname(verity_key_mincrypt))
|
|
shutil.copyfile(
|
|
os.path.join(self.testdata_dir, 'testkey_mincrypt'),
|
|
verity_key_mincrypt)
|
|
|
|
info_dict = {
|
|
'verity' : 'true',
|
|
}
|
|
options = {
|
|
'verity_key' : os.path.join(self.testdata_dir, 'testkey.x509.pem'),
|
|
'verity_key_mincrypt' : verity_key_mincrypt,
|
|
}
|
|
ValidateVerifiedBootImages(input_tmp, info_dict, options)
|