diff --git a/zip/zip.go b/zip/zip.go index 707c4ef16..3c710a782 100644 --- a/zip/zip.go +++ b/zip/zip.go @@ -145,7 +145,7 @@ func (b *FileArgsBuilder) List(name string) *FileArgsBuilder { } arg := b.state - arg.SourceFiles = strings.Split(string(list), "\n") + arg.SourceFiles = strings.Fields(string(list)) b.fileArgs = append(b.fileArgs, arg) return b } diff --git a/zip/zip_test.go b/zip/zip_test.go index 84317d1b6..9705d6c49 100644 --- a/zip/zip_test.go +++ b/zip/zip_test.go @@ -46,7 +46,8 @@ var mockFs = pathtools.MockFs(map[string][]byte{ "dangling -> missing": nil, "a/a/d -> b": nil, "c": fileC, - "l": []byte("a/a/a\na/a/b\nc\n"), + "l_nl": []byte("a/a/a\na/a/b\nc\n"), + "l_sp": []byte("a/a/a a/a/b c"), "l2": []byte("missing\n"), "manifest.txt": fileCustomManifest, }) @@ -224,7 +225,19 @@ func TestZip(t *testing.T) { { name: "list", args: fileArgsBuilder(). - List("l"), + List("l_nl"), + compressionLevel: 9, + + files: []zip.FileHeader{ + fh("a/a/a", fileA, zip.Deflate), + fh("a/a/b", fileB, zip.Deflate), + fh("c", fileC, zip.Deflate), + }, + }, + { + name: "list", + args: fileArgsBuilder(). + List("l_sp"), compressionLevel: 9, files: []zip.FileHeader{