StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Convert TestJavaSdkLibraryEnforce to test fixtures

Browse Source 
Bug: 182638834
Test: m nothing
Change-Id: I99efe76008f9ca0996177f47923274ca594a6858
This commit is contained in:
Paul Duffin
2021-03-12 21:28:51 +00:00
parent aa6caa7fa8
commit 05f72de083
1 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
java/java_test.go
View File

@@ -900,7 +900,7 @@ func TestJavaSdkLibraryEnforce(t *testing.T) {
allowList []string
}
createTestConfig := func(info testConfigInfo) android.Config {
createPreparer := func(info testConfigInfo) android.FixturePreparer {
bpFileTemplate := `
java_library {
name: "foo",
@@ -923,26 +923,26 @@ func TestJavaSdkLibraryEnforce(t *testing.T) {
info.libraryType,
partitionToBpOption(info.toPartition))
config := testConfig(nil, bpFile, nil)
configVariables := config.TestProductVariables
configVariables.EnforceProductPartitionInterface = proptools.BoolPtr(info.enforceProductInterface)
if info.enforceVendorInterface {
configVariables.DeviceVndkVersion = proptools.StringPtr("current")
}
configVariables.EnforceInterPartitionJavaSdkLibrary = proptools.BoolPtr(info.enforceJavaSdkLibraryCheck)
configVariables.InterPartitionJavaLibraryAllowList = info.allowList
return config
return android.GroupFixturePreparers(
android.FixtureWithRootAndroidBp(bpFile),
android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
variables.EnforceProductPartitionInterface = proptools.BoolPtr(info.enforceProductInterface)
if info.enforceVendorInterface {
variables.DeviceVndkVersion = proptools.StringPtr("current")
}
variables.EnforceInterPartitionJavaSdkLibrary = proptools.BoolPtr(info.enforceJavaSdkLibraryCheck)
variables.InterPartitionJavaLibraryAllowList = info.allowList
}),
)
}
runTest := func(t *testing.T, info testConfigInfo, expectedErrorPattern string) {
t.Run(fmt.Sprintf("%#v", info), func(t *testing.T) {
if expectedErrorPattern == "" {
testJavaWithConfig(t, createTestConfig(info))
} else {
testJavaErrorWithConfig(t, expectedErrorPattern, createTestConfig(info))
errorHandler := android.FixtureExpectsNoErrors
if expectedErrorPattern != "" {
errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(expectedErrorPattern)
}
javaFixtureFactory.ExtendWithErrorHandler(errorHandler).RunTest(t, createPreparer(info))
})
}