From bcd567ea12d826e304ca5725964e12141aae1e91 Mon Sep 17 00:00:00 2001 From: Alan Stokes Date: Fri, 12 Nov 2021 15:21:43 +0000 Subject: [PATCH] Make CompOS library optional in PRODUCT_APEX_SYSTEM_SERVER_JARS CompOS is an optional module so it may legitimately be omitted from some products. Bug: 199147668 Test: Builds if PRODUCT_ISOLATED_COMPILATION_ENABLED not set Change-Id: I4e031ca6184d920b64f9c370d35b5525ecbe8a1f --- java/systemserver_classpath_fragment.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/java/systemserver_classpath_fragment.go b/java/systemserver_classpath_fragment.go index d75635c43..e263cc44c 100644 --- a/java/systemserver_classpath_fragment.go +++ b/java/systemserver_classpath_fragment.go @@ -125,6 +125,12 @@ func (s *SystemServerClasspathModule) configuredJars(ctx android.ModuleContext) // TODO(b/203233647): Add better mechanism to make it optional. _, unknown = android.RemoveFromList("car-frameworks-service-module", unknown) + // This module is optional, so it is not present in all products. + // (See PRODUCT_ISOLATED_COMPILATION_ENABLED.) + // So ignore it even if it is not in PRODUCT_APEX_SYSTEM_SERVER_JARS. + // TODO(b/203233647): Add better mechanism to make it optional. + _, unknown = android.RemoveFromList("service-compos", unknown) + // TODO(satayev): for apex_test we want to include all contents unconditionally to classpaths // config. However, any test specific jars would not be present in ApexSystemServerJars. Instead, // we should check if we are creating a config for apex_test via ApexInfo and amend the values.