From f92c7154cd7c41939500f9194b18b8ea3e9c3185 Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Sun, 5 Sep 2021 19:53:15 -0700 Subject: [PATCH] Use tidyExternalVendor for external/googletest * Do not run expensive clang-analyzer-* checks with googletest/*, which should be checked upstream. Test: make WITH_TIDY=1 CLANG_ANALYZER_CHECKS=1 Bug: 198098397 Change-Id: Ic801ffa802b42d4d55ae89553073c926f9eaa351 --- cc/config/tidy.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cc/config/tidy.go b/cc/config/tidy.go index cf1350381..86825029e 100644 --- a/cc/config/tidy.go +++ b/cc/config/tidy.go @@ -115,6 +115,7 @@ var DefaultLocalTidyChecks = []PathBasedTidyCheck{ {"external/", tidyExternalVendor}, {"external/google", tidyDefault}, {"external/webrtc", tidyDefault}, + {"external/googletest/", tidyExternalVendor}, {"frameworks/compile/mclinker/", tidyExternalVendor}, {"hardware/qcom", tidyExternalVendor}, {"vendor/", tidyExternalVendor}, @@ -133,6 +134,7 @@ func reverseTidyChecks(in []PathBasedTidyCheck) []PathBasedTidyCheck { } func TidyChecksForDir(dir string) string { + dir = dir + "/" for _, pathCheck := range reversedDefaultLocalTidyChecks { if strings.HasPrefix(dir, pathCheck.PathPrefix) { return pathCheck.Checks