StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CpExecutable should not preserve symlink

Browse Source 
* When copy to an $out file, a symlink can become a dangling link.
* The following chmod +x will fail with a dangling link.

Bug: 241815504
Test: presubmit builds
Change-Id: Ic3dd9d41376a94381981fb973b41a1650f5ac946
This commit is contained in:
Chih-Hung Hsieh
2022-08-10 20:51:37 -07:00
committed by Chih-hung Hsieh
parent 9a5db000da
commit 1048a73f21
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
android/defs.go
View File

@@ -68,7 +68,7 @@ var (
CpExecutable = pctx.AndroidStaticRule("CpExecutable", CpExecutable = pctx.AndroidStaticRule("CpExecutable",
blueprint.RuleParams{ blueprint.RuleParams{
Command: "rm -f $out && cp $cpPreserveSymlinks $cpFlags $in $out && chmod +x $out$extraCmds", Command: "rm -f $out && cp $cpFlags $in $out && chmod +x $out$extraCmds",
Description: "cp $out", Description: "cp $out",
}, },
"cpFlags", "extraCmds") "cpFlags", "extraCmds")