Fix arm[64] cflags

Limit arm cpu variants to armv7-a-neon only, and handle a generic
armv7-a-neon cpu variant. Add arm64 cortex-a53 cpu variant. Sanity check
the arch variant against supported versions.

Change-Id: I8ecdea4cd36d9c82e1f29b158efc131f8b1cbc4d

cc/arm64_device.go

@@ -15,6 +15,7 @@
 package cc
 
 import (
+	"fmt"
 	"strings"
 
 	"android/soong/common"
@@ -72,6 +73,14 @@ var (
 	arm64Cppflags = []string{
 		"-fvisibility-inlines-hidden",
 	}
+
+	arm64CpuVariantCflags = map[string][]string{
+		"cortex-a53": []string{
+			"-mcpu=cortex-a53",
+		},
+	}
+
+	arm64ClangCpuVariantCflags = copyVariantFlags(arm64CpuVariantCflags)
 )
 
 const (
@@ -101,13 +110,31 @@ func init() {
 	pctx.StaticVariable("arm64ClangCflags", strings.Join(clangFilterUnknownCflags(arm64Cflags), " "))
 	pctx.StaticVariable("arm64ClangLdflags", strings.Join(clangFilterUnknownCflags(arm64Ldflags), " "))
 	pctx.StaticVariable("arm64ClangCppflags", strings.Join(clangFilterUnknownCflags(arm64Cppflags), " "))
+
+	pctx.StaticVariable("arm64CortexA53Cflags",
+		strings.Join(arm64CpuVariantCflags["cortex-a53"], " "))
+	pctx.StaticVariable("arm64ClangCortexA53Cflags",
+		strings.Join(arm64ClangCpuVariantCflags["cortex-a53"], " "))
 }
 
+var (
+	arm64CpuVariantCflagsVar = map[string]string{
+		"":           "",
+		"cortex-a53": "${arm64CortexA53Cflags}",
+	}
+
+	arm64ClangCpuVariantCflagsVar = map[string]string{
+		"":           "",
+		"cortex-a53": "${arm64ClangCortexA53Cflags}",
+	}
+)
+
 type toolchainArm64 struct {
 	toolchain64Bit
-}
 
-var toolchainArm64Singleton = &toolchainArm64{}
+	toolchainCflags      string
+	toolchainClangCflags string
+}
 
 func (t *toolchainArm64) Name() string {
 	return "arm64"
@@ -125,6 +152,10 @@ func (t *toolchainArm64) GccVersion() string {
 	return arm64GccVersion
 }
 
+func (t *toolchainArm64) ToolchainCflags() string {
+	return t.toolchainCflags
+}
+
 func (t *toolchainArm64) Cflags() string {
 	return "${arm64Cflags}"
 }
@@ -157,8 +188,19 @@ func (t *toolchainArm64) ClangLdflags() string {
 	return "${arm64Ldflags}"
 }
 
+func (t *toolchainArm64) ToolchainClangCflags() string {
+	return t.toolchainClangCflags
+}
+
 func arm64ToolchainFactory(arch common.Arch) Toolchain {
-	return toolchainArm64Singleton
+	if arch.ArchVariant != "armv8-a" {
+		panic(fmt.Sprintf("Unknown ARM architecture version: %q", arch.ArchVariant))
+	}
+
+	return &toolchainArm64{
+		toolchainCflags:      variantOrDefault(arm64CpuVariantCflagsVar, arch.CpuVariant),
+		toolchainClangCflags: variantOrDefault(arm64ClangCpuVariantCflagsVar, arch.CpuVariant),
+	}
 }
 
 func init() {

cc/arm_device.go

@@ -104,6 +104,9 @@ var (
 	}
 
 	armCpuVariantCflags = map[string][]string{
+		"": []string{
+			"-march=armv7-a",
+		},
 		"cortex-a7": []string{
 			"-mcpu=cortex-a7",
 			// Fake an ARM compiler flag as these processors support LPAE which GCC/clang
@@ -133,18 +136,6 @@ const (
 	armGccVersion = "4.9"
 )
 
-func copyVariantFlags(m map[string][]string) map[string][]string {
-	ret := make(map[string][]string, len(m))
-	for k, v := range m {
-		l := make([]string, len(m[k]))
-		for i := range m[k] {
-			l[i] = v[i]
-		}
-		ret[k] = l
-	}
-	return ret
-}
-
 func init() {
 	replaceFirst := func(slice []string, from, to string) {
 		if slice[0] != from {
@@ -192,6 +183,7 @@ func init() {
 	pctx.StaticVariable("armArmv7ANeonCflags", strings.Join(armArchVariantCflags["armv7-a-neon"], " "))
 
 	// Cpu variant cflags
+	pctx.StaticVariable("armGenericCflags", strings.Join(armCpuVariantCflags[""], " "))
 	pctx.StaticVariable("armCortexA7Cflags", strings.Join(armCpuVariantCflags["cortex-a7"], " "))
 	pctx.StaticVariable("armCortexA8Cflags", strings.Join(armCpuVariantCflags["cortex-a8"], " "))
 	pctx.StaticVariable("armCortexA15Cflags", strings.Join(armCpuVariantCflags["cortex-a15"], " "))
@@ -206,7 +198,7 @@ func init() {
 	pctx.StaticVariable("armClangArmCflags", strings.Join(clangFilterUnknownCflags(armArmCflags), " "))
 	pctx.StaticVariable("armClangThumbCflags", strings.Join(clangFilterUnknownCflags(armThumbCflags), " "))
 
-	// Clang cpu variant cflags
+	// Clang arch variant cflags
 	pctx.StaticVariable("armClangArmv5TECflags",
 		strings.Join(armClangArchVariantCflags["armv5te"], " "))
 	pctx.StaticVariable("armClangArmv7ACflags",
@@ -215,6 +207,8 @@ func init() {
 		strings.Join(armClangArchVariantCflags["armv7-a-neon"], " "))
 
 	// Clang cpu variant cflags
+	pctx.StaticVariable("armClangGenericCflags",
+		strings.Join(armClangCpuVariantCflags[""], " "))
 	pctx.StaticVariable("armClangCortexA7Cflags",
 		strings.Join(armClangCpuVariantCflags["cortex-a7"], " "))
 	pctx.StaticVariable("armClangCortexA8Cflags",
@@ -233,7 +227,7 @@ var (
 	}
 
 	armCpuVariantCflagsVar = map[string]string{
-		"":               "",
+		"":               "${armGenericCflags}",
 		"cortex-a7":      "${armCortexA7Cflags}",
 		"cortex-a8":      "${armCortexA8Cflags}",
 		"cortex-a15":     "${armCortexA15Cflags}",
@@ -250,7 +244,7 @@ var (
 	}
 
 	armClangCpuVariantCflagsVar = map[string]string{
-		"":               "",
+		"":               "${armClangGenericCflags}",
 		"cortex-a7":      "${armClangCortexA7Cflags}",
 		"cortex-a8":      "${armClangCortexA8Cflags}",
 		"cortex-a15":     "${armClangCortexA15Cflags}",
@@ -347,29 +341,43 @@ func (t *toolchainArm) ClangInstructionSetFlags(isa string) (string, error) {
 
 func armToolchainFactory(arch common.Arch) Toolchain {
 	var fixCortexA8 string
-	switch arch.CpuVariant {
+	toolchainCflags := make([]string, 2, 3)
-	case "cortex-a8", "":
+	toolchainClangCflags := make([]string, 2, 3)
-		// Generic ARM might be a Cortex A8 -- better safe than sorry
+
+	toolchainCflags[0] = "${armToolchainCflags}"
+	toolchainCflags[1] = armArchVariantCflagsVar[arch.ArchVariant]
+	toolchainClangCflags[0] = "${armToolchainClangCflags}"
+	toolchainClangCflags[1] = armClangArchVariantCflagsVar[arch.ArchVariant]
+
+	switch arch.ArchVariant {
+	case "armv7-a-neon":
+		switch arch.CpuVariant {
+		case "cortex-a8", "":
+			// Generic ARM might be a Cortex A8 -- better safe than sorry
+			fixCortexA8 = "-Wl,--fix-cortex-a8"
+		default:
+			fixCortexA8 = "-Wl,--no-fix-cortex-a8"
+		}
+
+		toolchainCflags = append(toolchainCflags,
+			variantOrDefault(armCpuVariantCflagsVar, arch.CpuVariant))
+		toolchainClangCflags = append(toolchainClangCflags,
+			variantOrDefault(armClangCpuVariantCflagsVar, arch.CpuVariant))
+	case "armv7-a":
 		fixCortexA8 = "-Wl,--fix-cortex-a8"
+	case "armv5te":
+		// Nothing extra for armv5te
 	default:
-		fixCortexA8 = "-Wl,--no-fix-cortex-a8"
+		panic(fmt.Sprintf("Unknown ARM architecture version: %q", arch.ArchVariant))
 	}
 
 	return &toolchainArm{
-		toolchainCflags: strings.Join([]string{
+		toolchainCflags: strings.Join(toolchainCflags, " "),
-			"${armToolchainCflags}",
-			armArchVariantCflagsVar[arch.ArchVariant],
-			armCpuVariantCflagsVar[arch.CpuVariant],
-		}, " "),
 		ldflags: strings.Join([]string{
 			"${armLdflags}",
 			fixCortexA8,
 		}, " "),
-		toolchainClangCflags: strings.Join([]string{
+		toolchainClangCflags: strings.Join(toolchainClangCflags, " "),
-			"${armToolchainClangCflags}",
-			armClangArchVariantCflagsVar[arch.ArchVariant],
-			armClangCpuVariantCflagsVar[arch.CpuVariant],
-		}, " "),
 	}
 }
 

cc/util.go

@@ -86,3 +86,22 @@ func flagsToBuilderFlags(in Flags) builderFlags {
 		clang:       in.Clang,
 	}
 }
+
+func copyVariantFlags(m map[string][]string) map[string][]string {
+	ret := make(map[string][]string, len(m))
+	for k, v := range m {
+		l := make([]string, len(m[k]))
+		for i := range m[k] {
+			l[i] = v[i]
+		}
+		ret[k] = l
+	}
+	return ret
+}
+
+func variantOrDefault(variants map[string]string, choice string) string {
+	if ret, ok := variants[choice]; ok {
+		return ret
+	}
+	return variants[""]
+}

common/arch.go

@@ -912,18 +912,20 @@ func decodeMegaDevice() ([]Arch, error) {
 		cpuVariant  string
 		abi         []string
 	}{
+		// armv5 is only used for unbundled apps
+		//{"arm", "armv5te", "", []string{"armeabi"}},
+		{"arm", "armv7-a", "generic", []string{"armeabi-v7a"}},
+		{"arm", "armv7-a-neon", "generic", []string{"armeabi-v7a"}},
 		{"arm", "armv7-a-neon", "cortex-a7", []string{"armeabi-v7a"}},
 		{"arm", "armv7-a-neon", "cortex-a8", []string{"armeabi-v7a"}},
-		// gtest_all_test.cc fails to build:
+		{"arm", "armv7-a-neon", "cortex-a9", []string{"armeabi-v7a"}},
-		//   error in backend: Unsupported library call operation!
-		//{"arm", "armv7-a-neon", "cortex-a9", []string{"armeabi-v7a"}},
 		{"arm", "armv7-a-neon", "cortex-a15", []string{"armeabi-v7a"}},
 		{"arm", "armv7-a-neon", "cortex-a53", []string{"armeabi-v7a"}},
 		{"arm", "armv7-a-neon", "cortex-a53.a57", []string{"armeabi-v7a"}},
 		{"arm", "armv7-a-neon", "denver", []string{"armeabi-v7a"}},
 		{"arm", "armv7-a-neon", "krait", []string{"armeabi-v7a"}},
-		{"arm64", "", "cortex-a53", []string{"arm64-v8a"}},
+		{"arm64", "armv8-a", "cortex-a53", []string{"arm64-v8a"}},
-		{"arm64", "", "denver64", []string{"arm64-v8a"}},
+		{"arm64", "armv8-a", "denver64", []string{"arm64-v8a"}},
 		{"mips", "mips32-fp", "", []string{"mips"}},
 		{"mips", "mips32r2-fp", "", []string{"mips"}},
 		{"mips", "mips32r2-fp-xburst", "", []string{"mips"}},