StrixOS/build_soong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Suggest using add_soong_config_ macros instead of direct variable assignments

Browse Source 
Bug: 190051051
Test: treehugger
Change-Id: Ib77d8af8f926412f6337173927cee6bb1deda2bb
This commit is contained in:
Sasha Smundak
2021-08-24 14:05:19 -07:00
parent 7c16dabfa5
commit 18fd099982
2 changed files with 8 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
README.md
View File

@@ -451,15 +451,10 @@ used. To specify that no properties should be amended for `soc_b`, you can set
The values of the variables can be set from a product's `BoardConfig.mk` file: The values of the variables can be set from a product's `BoardConfig.mk` file:
``` ```
SOONG_CONFIG_NAMESPACES += acme $(call add_soong_config_namespace, acme)
SOONG_CONFIG_acme += \ $(call add_soong_config_var_value, acme, board, soc_a)
board \ $(call add_soong_config_var_value, acme, feature, true)
feature \ $(call add_soong_config_var_value, acme, width, 200)
width \
SOONG_CONFIG_acme_board := soc_a
SOONG_CONFIG_acme_feature := true
SOONG_CONFIG_acme_width := 200
``` ```
The `acme_cc_defaults` module type can be used anywhere after the definition in The `acme_cc_defaults` module type can be used anywhere after the definition in

13
android/soong_config_modules.go
View File

@@ -122,15 +122,10 @@ type soongConfigModuleTypeImportProperties struct {
// } // }
// //
// If an acme BoardConfig.mk file contained: // If an acme BoardConfig.mk file contained:
// // $(call add_sonng_config_namespace, acme)
// SOONG_CONFIG_NAMESPACES += acme // $(call add_soong_config_var_value, acme, board, soc_a)
// SOONG_CONFIG_acme += \ // $(call add_soong_config_var_value, acme, feature, true)
// board \ // $(call add_soong_config_var_value, acme, width, 200)
// feature \
//
// SOONG_CONFIG_acme_board := soc_a
// SOONG_CONFIG_acme_feature := true
// SOONG_CONFIG_acme_width := 200
// //
// Then libacme_foo would build with cflags "-DGENERIC -DSOC_A -DFEATURE -DWIDTH=200". // Then libacme_foo would build with cflags "-DGENERIC -DSOC_A -DFEATURE -DWIDTH=200".
// //